Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should we use save! in set_google_secret method? #35

Closed
goromlagche opened this issue Sep 1, 2016 · 2 comments
Closed

should we use save! in set_google_secret method? #35

goromlagche opened this issue Sep 1, 2016 · 2 comments

Comments

@goromlagche
Copy link

set_google_secret method tries to save the record after setting google_secret https://github.com/jaredonline/google-authenticator/blob/master/lib/google-authenticator-rails/active_record/helpers.rb#L6

Question I have is should it use save!, as save does not raise any error.
@jaredonline
Copy link
Owner

Heya @goromlagche sorry its taken me 3.5 months to get back to you. Did you run into an issue where it was unable to set the secret and save? Maybe validations got in the way or something?

@mrj mrj mentioned this issue Nov 6, 2017
Merged
@jaredonline
Copy link
Owner

Closed by #41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaredonline @goromlagche