Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist for multiple refreshes #14

Merged
merged 2 commits into from
May 18, 2019

Conversation

krevels
Copy link
Contributor

@krevels krevels commented Dec 3, 2018

I ran into a problem similar to #12 where the form state would only restore on the first refresh, but would disappear on subsequent ones.

This appeared to occur because the <Persist /> component would update after mount, containing the initial form values. Additionally, this.context.formik is always null (I'm assuming b/c Formik no longer uses the legacy Context API), so it would cause whatever was in prevProps to always persist.

Replacing formik from the context with the one passed via props seemed like the easiest approach here, but I feel that i might be missing something 馃

@kuma-guy
Copy link

@jaredpalmer I need this to be merged!

@JulienWeiler
Copy link

Any news on this? Same issue here.

@nicodmf
Copy link

nicodmf commented Apr 16, 2019

@jaredpalmer Thanks for your light and usefull library. Can we have any news on this, this is central in persisting events ?

@ishakimanuel
Copy link

this issue still appear on my app with formik persist version 1.1.0, any solution for this issue ?

@nicodmf
Copy link

nicodmf commented May 2, 2019

@jaredpalmer it is very important PR, could you please review this.

@dunk
Copy link

dunk commented May 12, 2019

@jaredpalmer Could do with having this merged, too.

@jaredpalmer jaredpalmer merged commit d22ffb0 into jaredpalmer:master May 18, 2019
@vytautasvargonas
Copy link

Can we have a version released with this commit?

@abohannon
Copy link

Did this fix the issue? I'm still unable to persist after the second refresh.

@ashik112
Copy link

ashik112 commented Oct 14, 2019

Did this fix the issue? I'm still unable to persist after the second refresh.

No, still not fixed in version 1.1.0. Can we please have another version released with the fixes? @jaredpalmer

@collinc777
Copy link

@jaredpalmer just checking in here

@antoniojps
Copy link

antoniojps commented Feb 29, 2020

馃憖 Same issue.

@BearJS
Copy link

BearJS commented Mar 18, 2020

Same issue

1 similar comment
@rudyportillo
Copy link

Same issue

@Carus11
Copy link

Carus11 commented Apr 16, 2020

For those of you commenting that this issue persists in the published version, this library has only one code file (its very short and concise too), and the fix is in the master branch, you can grab that file and use it instead for the time being.

@ashik112
Copy link

Checking in after 1 year

@shamseerahammedm
Copy link

same issue here!

@kevinvugts
Copy link

@jaredpalmer re-opening this ticket since this one is still not release on the npm library. Would it be possible that you make a new build 1.1.2 on npm?

Thanks in advance. 馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet