-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Persist for multiple refreshes #14
Persist for multiple refreshes #14
Conversation
@jaredpalmer I need this to be merged! |
Any news on this? Same issue here. |
@jaredpalmer Thanks for your light and usefull library. Can we have any news on this, this is central in persisting events ? |
this issue still appear on my app with formik persist version 1.1.0, any solution for this issue ? |
@jaredpalmer it is very important PR, could you please review this. |
@jaredpalmer Could do with having this merged, too. |
Can we have a version released with this commit? |
Did this fix the issue? I'm still unable to persist after the second refresh. |
No, still not fixed in version 1.1.0. Can we please have another version released with the fixes? @jaredpalmer |
@jaredpalmer just checking in here |
馃憖 Same issue. |
Same issue |
1 similar comment
Same issue |
For those of you commenting that this issue persists in the published version, this library has only one code file (its very short and concise too), and the fix is in the master branch, you can grab that file and use it instead for the time being. |
Checking in after 1 year |
same issue here! |
@jaredpalmer re-opening this ticket since this one is still not release on the npm library. Would it be possible that you make a new build 1.1.2 on npm? Thanks in advance. 馃憤 |
I ran into a problem similar to #12 where the form state would only restore on the first refresh, but would disappear on subsequent ones.
This appeared to occur because the
<Persist />
component would update after mount, containing the initial form values. Additionally,this.context.formik
is always null (I'm assuming b/c Formik no longer uses the legacy Context API), so it would cause whatever was inprevProps
to always persist.Replacing
formik
from the context with the one passed via props seemed like the easiest approach here, but I feel that i might be missing something 馃