Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array-helper insert adds value to error state #1092

Open
marcel-devdude opened this issue Nov 8, 2018 · 5 comments
Open

Array-helper insert adds value to error state #1092

marcel-devdude opened this issue Nov 8, 2018 · 5 comments

Comments

@marcel-devdude
Copy link

馃悰 Bug report

Current Behavior

When i add an item to a FieldArray using insert the value is also inserted into the errors state (see example below).

Expected behavior

Only insert the value to the values state, not to the errors state.

Reproducible example

https://codesandbox.io/s/v87n4p6023

Your environment

Software Version(s)
Formik 1.3.1
React 16.5.2
@marcel-devdude marcel-devdude changed the title Array-helper insert add value to error state Array-helper insert adds value to error state Nov 8, 2018
@jaredpalmer
Copy link
Owner

Thanks for the sandbox. This is definitely a bug.

@jaredpalmer
Copy link
Owner

Can you submit a PR? Should be an easy fix.

@marcel-devdude
Copy link
Author

I have already submitted a PR: #1094

@UlyssesInvictus
Copy link

This is still an issue as of 2.1.1 and the thread for the linked PR has been stale for a year. Just commenting so that people can find it if they're wondering what's going on.

@udaysai1311
Copy link

Is the issue is closed or open? If it is open i would like to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants