Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optimization capabilities to connect #3110

Open
johnrom opened this issue Mar 23, 2021 · 4 comments
Open

Add optimization capabilities to connect #3110

johnrom opened this issue Mar 23, 2021 · 4 comments

Comments

@johnrom
Copy link
Collaborator

johnrom commented Mar 23, 2021

Currently connect passes Formik's full state to class components, but it could be more redux-like, selecting bits of state and being very optimized:

const RotateWhenSubmitting_Raw = (props: { isSubmitting: boolean }) => (
  <span className={`rotate-when-submitting ${props.isSubmitting ? "submitting" : ""}}>
    <SpinnerSvg />
  </span>
);
const RotateWhenSubmitting = connect(state => { isSubmitting: state.isSubmitting })(RotateWhenSubmitting_Raw);

This would be simple to do on top of #3089

@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 60 days

@github-actions github-actions bot added the stale label Apr 23, 2021
@johnrom johnrom removed the stale label Apr 23, 2021
@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 60 days

@github-actions github-actions bot added the stale label May 24, 2021
@johnrom johnrom removed the stale label May 24, 2021
@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 60 days

@github-actions github-actions bot added the stale label Jun 24, 2021
@johnrom johnrom removed the stale label Jun 24, 2021
@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 60 days

@github-actions github-actions bot added the stale label Jul 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant