Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yup validation dependency has no typings #37

Closed
alex-sherwin opened this issue Jul 7, 2017 · 5 comments
Closed

Yup validation dependency has no typings #37

alex-sherwin opened this issue Jul 7, 2017 · 5 comments
Labels
Type: Enhancement

Comments

@alex-sherwin
Copy link

alex-sherwin commented Jul 7, 2017 •
edited

Formik is written in TS (great), but your only validation option is yup, which has no typings in the main repo and there is no externally provided @types/yup package either.

Makes it difficult to try and adopt Formik while staying purely TS.
@jaredpalmer
Copy link
Owner

correct. I have already raised this issue. jquense/yup#91

@jaredpalmer
Copy link
Owner

Yup is no longer required. FYI

@Andreyco
Copy link
Collaborator

How? @jaredpalmer could you please elaborate on your last statement? Is it possible to inject validation lib of choice?

@jaredpalmer
Copy link
Owner

jaredpalmer commented Jul 30, 2017 •
edited

Since 0.8, validationSchema is optional. You can now use the validate option for custom async and sync validation.

@Andreyco
Copy link
Collaborator

Awesome! Nothing stopping me from using Formik at all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Andreyco @alex-sherwin @jaredpalmer