Allow setValues to extend rather than replace

[esbenp]

Current Behavior

Currently setValues will replace all current form state

Desired Behavior

A flag to change that behaviour to simply extend current values would be nice

Suggested Solution

I propose setValues signature is changed to setValues: (fields: { [field: string]: any }, replace?: bool = true) => void. Passing false would extend current values rather than replace it (ala values ={...currentValues, ...newValues}

Who does this impact? Who is this for?

The scenario I have experienced is sometimes I want a subform to override the values of the parent form. Therefore, I pass down setValues to the child that might override the values. However, I do not wish for the child to be unnecessarily aware of all parent values, so passing down values to do something like setValues({ ...values, [key]: newValue }) seems a bit much. In that case I could do setValues({ [key]: newValue }, false) instead. That way I do not have to worry about passing down the entire form's values nor extending setValues behaviour.

Describe alternatives you've considered

Right now I am passing down setValues={(childValues) => setValues({ ...values, ...childValues }) to the child instead of just passing setValues. It works fine, but it gets a bit cumbersome because I have to extend setValues this way everywhere where I need this behaviour.

Additional context

Other issue: #356

[esbenp]

Simple change suggestion in Formik.jsx:

setValues = (input: FormikValues, replace?: bool = true) => {
  const values = replace ? input : {...this.state.value, ...input}

  this.setState({ values }, () => {
    if (this.props.validateOnChange) {
    this.runValidations(values);
    }
  });
};

If the maintainers wish for this change to happen I can provide PR and test

[stale]

Hola! So here's the deal, between open source and my day job and life and what not, I have a lot to manage, so I use a GitHub bot to automate a few things here and there. This particular GitHub bot is going to mark this as stale because it has not had recent activity for a while. It will be closed if no further activity occurs in a few days. Do not take this personally--seriously--this is a completely automated action. If this is a mistake, just make a comment, DM me, send a carrier pidgeon, or a smoke signal.

[stale]

ProBot automatically closed this due to inactivity. Holler if this is a mistake, and we'll re-open it.

[BerekHalfhand]

Open up! Make it work like setState, please

[AdnanTheExcellent]

+1 for this feature.

[johnrom]

I'm reopening because there is actually movement here. See:

#1513
#1255

[viniciusdacal]

any updates on this? I could try to implement this, making it work like setState() as proposed on #1513