Fix jest noop, upgrade to Babel 7, use Yarn Workspaces, add create-razzle-app tests

[ghost]

Changes

• Upgrade to Babel 7 (closes Start migrating to babel 7.x #462, closes Migrate to Babel 7.x #464) (9ad42ac, de27f1f, d12ced3)
  • While keeping and extending babel-preset-razzle instead of using babel-preset-react-app.
    • It now supports options to pass to preset-env and preset-react instead of having them opaque and incurring in a full-blown manual configuration for minor tweaks (e.g., disabling async transforms or using target.browsers) (not tested yet).
  • Add support for .babelrc.js (994cf40)

• Use Yarn Workspaces instead of manual yarn link (8280275)
  • removes both yarn bootstrap and yarn clean
  • uses single yarn.lock
  • avoids conflicts
    • Before using Yarn Workspaces, tests were not passing because of Module build error similar to Module build failed: TypeError: Cannot read property 'loose' of undefined babel/babel#7110. It seems it was related to conflicting babel-core (see Module build failed: TypeError: Cannot read property 'loose' of undefined babel/babel#7110 (comment)) due to Jest: babel-jest depends on babel-core 6 and requires babel-core v7.0.0-bridge.0 to work with Babel 7.
  • yarn install takes care of removing unused packages and bootstrapping
  • lerna clean --yes is a preinstall script.

• Add yarn init:bin requirement for examples that depend on locally-compiled binaries (e8bd5f1)
  • Such as BuckleScript, which was slowing down install time significantly (due to bs-platform devDependency within with-reason-react)
  • When a package that compiles locally is added directly to devDependencies, yarn install performs an unnecessary, expensive operation. npm/yarn run init:bin bootstraps these requirements in userland via create-razzle-app, which was updated to handle the change.
  • with-elm and with-reason-react were updated with custom "pkg.init:bin"
  • CONTRIBUTING.md was updated accordingly
• Refactor create-razzle-app to allow testing with local examples (e8bd5f1)
  • It was hardcoded to retrieve examples from origin; this made it impossible to test it with local changes without merging.
• Add create-razzle-app tests (to also cover yarn init:bin) (0b1c71e)
• Use CRA-like config/polyfills in createJestConfig (as per Start migrating to babel 7.x #462 (comment)) (a45375d, c5e90c4)

Fixes

• yarn e2e was not actually running tests because of a faulty --config. See CircleCI yarn e2e —runInBand output. (185b0d4)
• Fix failing tests (try jest --verbose --no-cache on master).
• Upgrade all dependencies (including examples’) (39aa1f7) (closes Upgrade to Jest 22 #438)
• Extend Prettier to .json, .css, and .md (4b7ee26)
• Add CSS Modules-specific settings to createJestConfig (taken from CRA) (e689fa2) (related to Css modules #459)
• Minor (aace259, 1f0f249, 9b66b81, 6bd5bc0, 743e44c, e689fa2, 42532b4, b2ecef3) (closes Update eslint to latest version 4.11.0 #404; untested)

Yarn Workspaces Caveats

• To add a devDependencies package to a workspace, yarn add package —dev must be executed within a workspace folder rather anywhere else with yarn workspace workspace-name add package —dev (pending yarn workspaces <workspace> add <package> -D adds to <workspace> dependencies yarnpkg/yarn#5396; related to Yarn workspace fails to add local package as dependency yarnpkg/yarn#4878 and Cannot yarn add in workspace package if depending on a local package yarnpkg/yarn#3973)
  1. cd to workspace-name (e.g., cd packages/create-razzle-app)
  2. yarn add package --dev (e.g., yarn add @babel/runtime --dev)
• To add a dependencies package to the root workspace (i.e., ./package.json), use yarn add package --ignore-workspace-root-check (see Cannot add a regular dependency to a workspace root yarnpkg/yarn#4558). To add a devDependencies package to the root workspace yarn add package --dev.
• yarn install reinstalls all packages every time (pending Adding package to workspace reinstalls all packages yarnpkg/yarn#4980)

Caveats

• Compile soft-failure webpack critical dependency (Warning: Critical dependencies. webpack/webpack#196) when compiling basic (and possibly all others?) due to Express (not a significant issue given it’s server-side).
• psKill logs Could not kill process when running tests due to conservative kill(process.pid) use in exports.run in test/utils/common due to occasional EADDRINUSE :::3001 issues (i.e., processes not being terminated).
• Should tests fail with EADDRINUSE :::3001 then sudo lsof -ti:3001 | xargs kill -9 (on >= El Capitan) (related to yarn run fails due to port 3001 already in use #454 and Check for port in use when running npm run start to avoid EADDRINUSE #397)

• All tests passing.
• All commits referenced.
• Document babel-preset-razzle preset-env and preset-react options.
• Document usage with Yarn Workspaces and remove yarn bootstrap and yarn clean mentions.
• Document all caveats for contributors.

[olehreznichenko]

Waiting to razzle v2.1.0 😄

[jaredpalmer]

Most of this is in 2.x

The init:bin, jestConfig, and Babel 7 are still on the to-do list

[stale]

Hola! So here's the deal, between open source and my day job and life and what not, I have a lot to manage, so I use a GitHub bot to automate a few things here and there. This particular GitHub bot is going to mark this as stale because it has not had recent activity for a while. It will be closed if no further activity occurs in a few days. Do not take this personally--seriously--this is a completely automated action. If this is a mistake, just make a comment, DM me, send a carrier pidgeon, or a smoke signal.

[stale]

ProBot automatically closed this due to inactivity. Holler if this is a mistake, and we'll re-open it.