Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore rollup-plugin-visualizer #496

Closed
jaredpalmer opened this issue Feb 6, 2020 · 3 comments · Fixed by #705
Closed

Explore rollup-plugin-visualizer #496

jaredpalmer opened this issue Feb 6, 2020 · 3 comments · Fixed by #705
Labels
good first issue Good for newcomers help wanted Extra attention is needed kind: feature New feature or request solution: workaround available There is a workaround available for this issue

Comments

@jaredpalmer
Copy link
Owner

Seems useful. Perhaps we add an --inspect flag?

@swyxio swyxio added good first issue Good for newcomers help wanted Extra attention is needed labels Feb 6, 2020
@arvinsim
Copy link

arvinsim commented Feb 10, 2020

Were you guys able to make rollup-plugin-visualizer work without resorting to the objectHashIgnoreUnknownHack hack to circumvent the asyncfunction issue?

@agilgur5
Copy link
Collaborator

@arvinsim I'm fairly certain your hunch is correct that this is blocked on puleos/object-hash#90 .
In theory disabling rpts2's cache only during --inspect isn't that bad, but I'm not a big fan of adding a hack on top of a hack to the codebase as that can lead to unexpected issues, esp. when they involve caching.

@agilgur5
Copy link
Collaborator

Ok so puleos/object-hash#90 was just merged and released so now we're blocked on ezolenko/rollup-plugin-typescript2#203 (PR from me).

Notably, rollup-plugin-visualizer was mentioned in #200 as an explicit example of one of the things that wasn't possible due to rpts2's lack of async/await support.

I mentioned in puleos/object-hash#90 that it'd be difficult to fork/patch a transitive dependency, but this actually goes a step further as rpts2 doesn't have externals for its dependencies and actually bundles them in its own release (ezolenko/rollup-plugin-typescript2#80, ezolenko/rollup-plugin-typescript2#70), so TSDX can't override the version of object-hash that rpts2 uses (on top of having duplicated dependencies included in it...) 😕 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed kind: feature New feature or request solution: workaround available There is a workaround available for this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants