Option to not warn on missing files

jaredpar · Jul 6, 2017 · b5af8e8 · b5af8e8
1 parent 26fb807
commit b5af8e8
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 3 deletions.
diff --git a/src/GitLink/Extensions/RepositoryExtensions.cs b/src/GitLink/Extensions/RepositoryExtensions.cs
@@ -18,7 +18,7 @@ internal static class RepositoryExtensions
         private static readonly ILog Log = LogManager.GetCurrentClassLogger();
         private static readonly char[] PathSeparators = new char[] { Path.DirectorySeparatorChar, Path.AltDirectorySeparatorChar };
 
-        internal static string GetNormalizedPath(this Repository repository, string path)
+        internal static string GetNormalizedPath(this Repository repository, string path, bool warnOnMissingFiles = true)
         {
             Argument.IsNotNull(nameof(repository), repository);
             Argument.IsNotNullOrEmpty(nameof(path), path);
@@ -39,7 +39,11 @@ internal static string GetNormalizedPath(this Repository repository, string path
 
                 if (entry == null)
                 {
-                    Log.Warning($"Unable to find file in git: \"{path}\".");
+                    if (warnOnMissingFiles)
+                    {
+                        Log.Warning($"Unable to find file in git: \"{path}\".");
+                    }
+
                     return path;
                 }
 

diff --git a/src/GitLink/LinkOptions.cs b/src/GitLink/LinkOptions.cs
@@ -18,6 +18,8 @@ public struct LinkOptions
 
         public bool SkipVerify { get; set; }
 
+        public bool SkipWarningOnMissingFiles { get; set; }
+
         public Uri GitRemoteUrl { get; set; }
 
         public string CommitId { get; set; }

diff --git a/src/GitLink/Linker.cs b/src/GitLink/Linker.cs
@@ -100,7 +100,8 @@ public static bool Link(string pdbPath, LinkOptions options = default(LinkOption
                     try
                     {
                         Repository repo = repository.Value;
-                        repoSourceFiles = sourceFiles.ToDictionary(e => e, e => repo.GetNormalizedPath(e));
+                        var warnOnMissingFiles = !options.SkipWarningOnMissingFiles;
+                        repoSourceFiles = sourceFiles.ToDictionary(e => e, e => repo.GetNormalizedPath(e, warnOnMissingFiles));
                     }
                     catch (RepositoryNotFoundException)
                     {

diff --git a/src/GitLinkTask/GitLink.props b/src/GitLinkTask/GitLink.props
@@ -3,5 +3,6 @@
   <PropertyGroup>
     <GitLinkEnabled Condition=" '$(DesignTimeBuild)' != 'true' and '$(Configuration)' == 'Release' and '$(GitLinkEnabled)' == '' and $(BuildingForLiveUnitTesting) != 'true' ">true</GitLinkEnabled>
     <GitLinkContinueOnError>true</GitLinkContinueOnError>
+    <GitLinkWarnOnMissingFiles>true</GitLinkWarnOnMissingFiles>
   </PropertyGroup>
 </Project>
diff --git a/src/GitLinkTask/GitLink.targets b/src/GitLinkTask/GitLink.targets
@@ -13,6 +13,7 @@
         GitRemoteUrl="$(GitLinkGitRemoteUrl)"
         GitWorkingDirectory="$(GitWorkingDirectory)"
         GitCommitId="$(GitCommitId)"
+        WarnOnMissingFiles="$(GitLinkWarnOnMissingFiles)"
         ContinueOnError="$(GitLinkContinueOnError)" />
   </Target>
 </Project>
diff --git a/src/GitLinkTask/LinkPdbToGitRemote.cs b/src/GitLinkTask/LinkPdbToGitRemote.cs
@@ -27,6 +27,8 @@ public string Method
 
         public string GitWorkingDirectory { get; set; }
 
+        public bool WarnOnMissingFiles { get; set; }
+
         private LinkMethod MethodEnum { get; set; }
 
         public override bool Execute()
@@ -37,6 +39,7 @@ public override bool Execute()
             {
                 Method = MethodEnum,
                 SkipVerify = SkipVerify,
+                SkipWarningOnMissingFiles = !WarnOnMissingFiles,
                 GitRemoteUrl = GitRemoteUrl != null ? new Uri(GitRemoteUrl, UriKind.Absolute) : null,
                 CommitId = GitCommitId,
                 GitWorkingDirectory = GitWorkingDirectory,