-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes colors #1359
Merged
Merged
Fixes colors #1359
Commits on Apr 12, 2014
-
Basic options support for caret color
So much work needed here but have a really basic implementation of supporting the block caret color on the options page. Need to really refactor the code and add support for the other colors. This is a good point to start from
Configuration menu - View commit details
-
Copy full SHA for 8c0235e - Browse repository at this point
Copy the full SHA 8c0235eView commit details -
Renamed Constants -> VimConstants
The name "Constants" was causing ambiguity errors in the code base. Renamed to VimConstants to remove that ambiguity
Configuration menu - View commit details
-
Copy full SHA for fc6c2ea - Browse repository at this point
Copy the full SHA fc6c2eaView commit details -
Everything is basically working except the encoding and decoding of color values. The code today assumes they are always RGB but they can be other values as well. Need to work out the other values
Configuration menu - View commit details
-
Copy full SHA for 6584d47 - Browse repository at this point
Copy the full SHA 6584d47View commit details
Commits on Apr 15, 2014
-
More intelligent color loading
Change the color loading code to use IVsFontAndColorUtilities. This allows for proper decoding of the COLORREF value. Still some issues with getting CT_COLORINDEX correctly decoding. Waiting to hear back from VS team on how that should work
Configuration menu - View commit details
-
Copy full SHA for 5cfcad3 - Browse repository at this point
Copy the full SHA 5cfcad3View commit details -
Configuration menu - View commit details
-
Copy full SHA for b5a8dab - Browse repository at this point
Copy the full SHA b5a8dabView commit details -
Right now only loading foreground, in some cases like toast margin we care about background. May want to eventually limit the colors we support
Configuration menu - View commit details
-
Copy full SHA for fde2bb2 - Browse repository at this point
Copy the full SHA fde2bb2View commit details -
1. The option page will no longer unconditionally save the translated Color value. Instead it will now only save values which have actually changed. 2. Failing to load one color affects that color only. All other colors can still be loaded and saved even with the single failure
Configuration menu - View commit details
-
Copy full SHA for 634d368 - Browse repository at this point
Copy the full SHA 634d368View commit details -
This removes the possibility of returning all of the CT_ values that can't be easily dealt with
Configuration menu - View commit details
-
Copy full SHA for f65766c - Browse repository at this point
Copy the full SHA f65766cView commit details
Commits on Apr 22, 2014
-
Configuration menu - View commit details
-
Copy full SHA for cb37f18 - Browse repository at this point
Copy the full SHA cb37f18View commit details -
Configuration menu - View commit details
-
Copy full SHA for a4dd2a0 - Browse repository at this point
Copy the full SHA a4dd2a0View commit details
Commits on Apr 23, 2014
-
Cleaned up the color definitions
All are now uniformly defined and properly disable the customization of the foreground / background they don't support
Configuration menu - View commit details
-
Copy full SHA for fb2d95d - Browse repository at this point
Copy the full SHA fb2d95dView commit details -
Configuration menu - View commit details
-
Copy full SHA for cb9e1ef - Browse repository at this point
Copy the full SHA cb9e1efView commit details -
Configuration menu - View commit details
-
Copy full SHA for 591e6a8 - Browse repository at this point
Copy the full SHA 591e6a8View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.