Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes colors #1359

Merged
merged 13 commits into from
Apr 23, 2014
Merged

Fixes colors #1359

merged 13 commits into from
Apr 23, 2014

Commits on Apr 12, 2014

  1. Basic options support for caret color

    So much work needed here but have a really basic implementation of
    supporting the block caret color on the options page.  Need to really
    refactor the code and add support for the other colors.  This is a good
    point to start from
    jaredpar committed Apr 12, 2014
    Configuration menu
    Copy the full SHA
    8c0235e View commit details
    Browse the repository at this point in the history
  2. Renamed Constants -> VimConstants

    The name "Constants" was causing ambiguity errors in the code base.
    Renamed to VimConstants to remove that ambiguity
    jaredpar committed Apr 12, 2014
    Configuration menu
    Copy the full SHA
    fc6c2ea View commit details
    Browse the repository at this point in the history
  3. Multiple colors supported

    Everything is basically working except the encoding and decoding of
    color values.  The code today assumes they are always RGB but they can
    be other values as well.  Need to work out the other values
    jaredpar committed Apr 12, 2014
    Configuration menu
    Copy the full SHA
    6584d47 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2014

  1. More intelligent color loading

    Change the color loading code to use IVsFontAndColorUtilities.  This
    allows for proper decoding of the COLORREF value.  Still some issues
    with getting CT_COLORINDEX correctly decoding.  Waiting to hear back
    from VS team on how that should work
    jaredpar committed Apr 15, 2014
    Configuration menu
    Copy the full SHA
    5cfcad3 View commit details
    Browse the repository at this point in the history
  2. Fix CT_COLORINDEX handling

    jaredpar committed Apr 15, 2014
    Configuration menu
    Copy the full SHA
    b5a8dab View commit details
    Browse the repository at this point in the history
  3. Added all the colors in

    Right now only loading foreground, in some cases like toast margin we
    care about background.  May want to eventually limit the colors we
    support
    jaredpar committed Apr 15, 2014
    Configuration menu
    Copy the full SHA
    fde2bb2 View commit details
    Browse the repository at this point in the history
  4. Color info more rigorous

    1. The option page will no longer unconditionally save the translated
    Color value.  Instead it will now only save values which have actually
    changed.
    
    2. Failing to load one color affects that color only.  All other colors
    can still be loaded and saved even with the single failure
    jaredpar committed Apr 15, 2014
    Configuration menu
    Copy the full SHA
    634d368 View commit details
    Browse the repository at this point in the history
  5. Use FCSF_NOAUTOCOLORS flag

    This removes the possibility of returning all of the CT_ values that
    can't be easily dealt with
    jaredpar committed Apr 15, 2014
    Configuration menu
    Copy the full SHA
    f65766c View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2014

  1. Configuration menu
    Copy the full SHA
    cb37f18 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a4dd2a0 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2014

  1. Cleaned up the color definitions

    All are now uniformly defined and properly disable the customization of
    the foreground / background they don't support
    jaredpar committed Apr 23, 2014
    Configuration menu
    Copy the full SHA
    fb2d95d View commit details
    Browse the repository at this point in the history
  2. Removed unnecessary colors

    jaredpar committed Apr 23, 2014
    Configuration menu
    Copy the full SHA
    cb9e1ef View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    591e6a8 View commit details
    Browse the repository at this point in the history