Fix MEF composition error #2386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a MEF composition error that occurs more frequently on older versions of Visual Studio. There appears to be a timing issue with accessing the output window on the UI thread during composition. Unfortunately I'm not able to see what is going wrong as it's happening within the DTE layer. The fix though is pretty straight forward: 1. Delay the initialization of the Output Window to idle 1. Catch exceptions coming from that code and raise errors vs. letting them be unhandled closes #2249
|
It sounds like you were able to repro the issue. That's great! |
|
Yeah finally reproduced this. I'm still not entirely sure what is needed to make it happen. I have a number of machines with VS2107 and VS2015 installed but only one reproduced this issue. Think it may have something to do with the solution state loading. Essentially whether or not the output window was visible when you last closed the solution or something along those lines. Either way though fix is basically the same. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a MEF composition error that occurs more frequently on older
versions of Visual Studio. There appears to be a timing issue with
accessing the output window on the UI thread during composition.
Unfortunately I'm not able to see what is going wrong as it's happening
within the DTE layer. The fix though is pretty straight forward:
them be unhandled
closes #2249