Added --nopreview option #23
Conversation
| @@ -23,6 +23,7 @@ program | |||
| program | |||
| .command('start') | |||
| .description('start streaming video from the raspberry pi camera module') | |||
| .option('-n, --nopreview', 'Removes the preview screen') | |||
There was a problem hiding this comment.
Shouldn't be a preview screen at all, so an option isn't necessary.
There was a problem hiding this comment.
On the Pi 3, I keep getting the preview screen opening up and taking over the screen, preventing any interaction with the Pi. Only solution is to restart the Pi. This flag allows me to prevent the preview from opening up in the first place.
There was a problem hiding this comment.
On the Pi 3, I keep getting the preview screen opening up and taking over the screen, preventing any interaction with the Pi.
Right. raspi-live shouldn't be opening a preview screen at all and no one should want it to, so the option isn't needed.
There was a problem hiding this comment.
Moved your comment from the main PR body back to this thread:
raspy-live is the package that IS opening the preview by default, so I had no choice but to add the option and use it.
You don't need to add this option to raspi-live, just to the list of options given to raspivid in server.js like you did below. Adding the option in cli.js doesn't actually do anything. If you were to remove just this line, nothing would change.
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "name": "raspi-live", | |||
| "name": "raspi-live-v2", | |||
There was a problem hiding this comment.
Version revisions aren't done in the package.json name field. Please revise the version field instead with a patch update.
|
@rchvalbo Thanks for taking the time to improve raspilive. Take a look at the pull request review comments for next steps 👍 |
|
raspy-live is the package that IS opening the preview by default, so I had no choice but to add the option and use it.
Roman C.
… On Apr 24, 2019, at 9:44 PM, Jared Petersen ***@***.***> wrote:
@jaredpetersen commented on this pull request.
In cli.js:
> @@ -23,6 +23,7 @@ program
program
.command('start')
.description('start streaming video from the raspberry pi camera module')
+ .option('-n, --nopreview', 'Removes the preview screen')
On the Pi 3, I keep getting the preview screen opening up and taking over the screen, preventing any interaction with the Pi.
Right. raspi-live shouldn't be opening a preview screen at all and no one should want it to, so the option isn't needed.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Closing since I had to continue this work in another PR (#30). This needed a proper version revision and didn't need a new option for nopreview in the raspi-live CLI. Since the change was small and this hasn't been touched in many months, I just made the change myself. |
This will allow for the ability to prevent the preview window from opening on start.