-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use notie.alert with an enum for types? #28
Comments
Thanks for the feedback though it's definitely easier to type "2" than "notie.types.WARNING". Feel free to pursue this on your forks! |
Sounds good, thanks for considering it. It would still work to type either |
Ah I see thank you for explaining. Perhaps I will still implement this. Thanks again. |
Let me know if you would like me to open a pull request. |
I think enums would be a good idea along with simple integers, just thinking if there is a way to reference them without going through notie.types.X |
I'm still not convinced how notie.type.success is easier to remember than "1". It's unlikely there'll ever be more than 4 categories (sucess/error/warning/info) so is remembering that 1-4 are your choices really not sufficient? Just my $0.02 |
I'll definitely be nuking my fork with up to 16 variations. |
I find it easier to remember enums than numbers.
README.md
notie.js
The text was updated successfully, but these errors were encountered: