Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update html css to support word-breaking on long lines #159

Merged
merged 2 commits into from
Apr 25, 2022
Merged

Update html css to support word-breaking on long lines #159

merged 2 commits into from
Apr 25, 2022

Conversation

nisrulz
Copy link
Contributor

@nisrulz nisrulz commented Sep 12, 2021

This is a duplicate PR of #101. The old PR is abandoned and has conflicts, thus creating a new one.

This work was originally done by @kgbier

TODO:

  • Add screenshots

@jaredsburrows
Copy link
Owner

Sync and add screenshots?

@nisrulz
Copy link
Contributor Author

nisrulz commented Apr 21, 2022

@jaredsburrows I have synced and removed all conflicts from this branch.

I remember I wasn't sure how to take the screenshots in this case.

Wouldn't you say that this repo needs to have a sample app to demonstrate the integration, thus enabling even taking automated screenshots for each PR and also loading the plugin as a module?

I am not sure how to feed in the plugin in this case, where the plugin code is modified. I understand the mavenLocal publishing when dealing with Android libs and that would allow me to publish the modified code to my own local maven repo. Then I can load the plugin from my local system, to generate the screenshot.

Since this is a plugin, I am not sure. Maybe some pointers how you would do that would help me.

@nisrulz nisrulz marked this pull request as ready for review April 21, 2022 00:17
@jaredsburrows
Copy link
Owner

Sorry for the churn, is break-word deprecated? See: https://developer.mozilla.org/en-US/docs/Web/CSS/word-break.

@nisrulz
Copy link
Contributor Author

nisrulz commented Apr 22, 2022

Interesting. I didn't know that. Let me look into it. Will update it here.

@nisrulz
Copy link
Contributor Author

nisrulz commented Apr 24, 2022

I think the deprecated property is supposed to be still used since the alternatives might only work on latest versions. The deprecated property will keep working for sometime, considering the webkit on Android is usually not updated across all Android versions.

Here is Chrome platform mentioning some info on the alternative (https://chromestatus.com/feature/5126089347170304):

The CSS Text 3 spec still allows the 'break-word' value to ensure compatibility (Safari and Chrome support it), but its marked as deprecated; that's why Firefox doesn't implement it.

The 'word-break: break-word' feature provides a behavior that web authors really appreciate, which consist on breaking opportunities account for the min-content size.

Several approaches have been explored, but all of them lead to serious web compatibility issues, so that the CSS WG resolved that a new CSS value should be the best solution.

@jaredsburrows jaredsburrows merged commit a9f4715 into jaredsburrows:master Apr 25, 2022
@jaredsburrows
Copy link
Owner

Thanks!

@nisrulz nisrulz deleted the update/html-css branch April 25, 2022 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants