Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue #26 Recursively scan parent POMs for license #27

Merged
merged 2 commits into from
Jan 9, 2018
Merged

issue #26 Recursively scan parent POMs for license #27

merged 2 commits into from
Jan 9, 2018

Conversation

ChristianCiach
Copy link
Contributor

Related to pull request #23

@ChristianCiach
Copy link
Contributor Author

References issue #26

@ChristianCiach
Copy link
Contributor Author

ChristianCiach commented Jan 9, 2018 •
edited

Dammit, I accidently push both changes to the same branch/pull request again!

Well, you said that you don't mind. And this time the commits have the correct author, so I will leave it like this. I will now take a look at the README.

Turns out, force pushes to pull requests are possible.

This was referenced Jan 9, 2018
Merged
Closed
@jaredsburrows jaredsburrows merged commit 351ef1b into jaredsburrows:master Jan 9, 2018
@jaredsburrows
Copy link
Owner

Thanks!

@jaredsburrows
Copy link
Owner

This should close #15 and #26.

This was referenced Jan 9, 2018
Closed
Closed
@ChristianCiach
Copy link
Contributor Author

@jaredsburrows
Regarding this point:

Maybe add a test with one of the Square libraries to test the parent POM search?

I not fluent enough with Groovy to comfortably write a new unit test (more accurate: "I don't wanna"), so I've changed the current POM-structure for the existing parent-POM-test with an additional grandparent-POM that contains the actual license information. This unit test still succeeds, to this should confirm that recursive parent POM search works.

@jaredsburrows
Copy link
Owner

@ChristianCiach Thanks for that!

@jaredsburrows jaredsburrows mentioned this pull request Mar 14, 2018
Closed
@jaredsburrows jaredsburrows mentioned this pull request Apr 23, 2019
Closed
@ChristianCiach ChristianCiach mentioned this pull request Apr 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredsburrows jaredsburrows jaredsburrows approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ChristianCiach @jaredsburrows