Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #229 #312

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Fix issue #229 #312

merged 2 commits into from
Aug 1, 2023

Conversation

realdadfish
Copy link
Contributor

No description provided.

@realdadfish realdadfish force-pushed the silence-warning branch 2 times, most recently from 2dd7511 to 66aeebb Compare June 8, 2023 09:16
@jaredsburrows
Copy link
Owner

@realdadfish Rebase this and can we pass e as parameter instead?

Do not print stacktraces for warnings, just for debug messages
912c9a1 
Shorten messages of causes to 200 chars max.

Fixes issue jaredsburrows#229
@realdadfish
Copy link
Contributor Author

@jaredsburrows PR is rebased. Initially I just passed e, but the problem is that we have some very verbose variant-resolving exception messages that span 10+ lines which then still spam the log quite a lot. I found no other way of getting a "condensed" / "shortened" exception message other than manually shrinking the exception message string itself.

@jaredsburrows jaredsburrows merged commit 08ad300 into jaredsburrows:master Aug 1, 2023
2 checks passed
@jaredsburrows
Copy link
Owner

Thanks!

@jaredsburrows jaredsburrows mentioned this pull request Aug 1, 2023
Closed
@realdadfish realdadfish deleted the silence-warning branch August 1, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@realdadfish @jaredsburrows