Fix exponential execution time for resolving complex dependencies #398
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #394.
This PR improves the performance of
getResolvedArtifactsFromResolvedDependencies
by recording the dependencies that have already been processed.This allows the function that used to take exponential time in the worst case to now be done in linear time.
The test I wrote takes about 2 minutes on my machine before the patch is applied, but now takes only a few seconds after the patch is applied.