Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

POM artifact resolution #463

Merged
merged 6 commits into from
Apr 8, 2024
Merged

POM artifact resolution #463

merged 6 commits into from
Apr 8, 2024

Conversation

t-beckmann
Copy link
Contributor

@t-beckmann t-beckmann commented Apr 8, 2024 •
edited
Loading

This PR improves the parent POM resolution adressing the build cache issues mentioned at #338 (comment) by

  • using an artifact resolution query instead of a temporary configuration repeatedly modified
  • avoids appending a random value to POM configuration generated by using the task name instead
  • prefers the license named by the original author even if the URL happens to be invalid

@t-beckmann
resolve parent POM using ArtifactResolutionQuery avoiding temporary c…
7b72f2f 
…onfiguration

Signed-off-by: Thomas Beckmann <thomas.beckmann@relution.io>
@t-beckmann
tempPomConfiguration is no longer needed
2ec984a 
Signed-off-by: Thomas Beckmann <thomas.beckmann@relution.io>
@t-beckmann
use task name instead of random UUID for naming pom configuration so …
d3853a6 
…that resulting names are reproducible

Signed-off-by: Thomas Beckmann <thomas.beckmann@relution.io>
@t-beckmann
configurations no longer needs to be passed down the line
9dddd8e 
Signed-off-by: Thomas Beckmann <thomas.beckmann@relution.io>
@t-beckmann
when a license is named by the POM author prefer it and do not use pa…
a710914 
…rent POM license even if URL is invalid

Signed-off-by: Thomas Beckmann <thomas.beckmann@relution.io>
@t-beckmann
resolve klint issues
6d41e33 
Signed-off-by: Thomas Beckmann <thomas.beckmann@relution.io>
@jaredsburrows jaredsburrows merged commit 3d6676d into jaredsburrows:master Apr 8, 2024
2 checks passed
@jaredsburrows
Copy link
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@t-beckmann @jaredsburrows