Fix for #52 - Eliminate Duplicate Licenses #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 14, 2018 15:49
|
@iankerr Since I merged your other PR, can you fix your conflicts? |
…ows#53) * make any links to licenses clickable in preformatted text * fix failing test * rename currentProjectName to CurrentLicenseName
|
Hmmm... I merged in your recent changes, and now the build is failing. Error: "Could not create an instance of Tooling API implementation using the specified Gradle distribution 'https://services.gradle.org/distributions/gradle-3.4-bin.zip'" Any idea what's wrong? |
jaredsburrows
added a commit
that referenced
this pull request
Dec 19, 2018
This reverts commit 9a8a3a5.
jaredsburrows
added a commit
that referenced
this pull request
Dec 19, 2018
This reverts commit 9a8a3a5.
|
Sorry. I merged without fixing the build. Do you mind pushing this back up so we can merge it? |
|
I've re-created the pull request: #57 ...hopefully that's what you're asking for? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is is a proposed fix for issue #52
I changed the HtmlReport class a bit to lookup licenses in the license map by url and name, and group them all together in the report.
Also:
-adds elements for all licenses (including "no license) - not just the ones in the license map
-updates tests to reflect my changes
-adds more names/urls for the Apache 2.0 license
-adds the CC0 1.0 Universal license to the map