Feature - option to copy reports into variant-specific asset directories #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you resolve conflicts so we can clean up and merge? |
|
Updated to the new project code. I've tested it in our project with jitpack and it works as expected. |
jaredsburrows
force-pushed
the
master
branch
3 times, most recently
from
98960ab
to
cf981d6
Compare
|
@rabidaudio Sorry for late reply, can you sync this and we can merge it? |
|
@jaredsburrows sync'd! |
| it.assetDirs = baseExtension | ||
| .sourceSets | ||
| .getByName("main") | ||
| .getByName(sourceSetName) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I appreciate the plugin!
I noticed that the
copy*ReportToAssetsoptions put the assets in themainassets folder, but we have multiple flavors in our app so to keep them from overwriting each other I added an optionuseVariantSpecificAssetDirsthat puts them in the flavor-specific asset folder. I could see this as a first step to alicenseReporttask that would generate reports for all variants. I'm not sold on the option name and open to changes to the api or implementation. Also totally understand if this is a feature you don't want to support.I'm not sure how good the test is, I'm not very familiar with the test framework.