Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Gson for Json #84

Merged
merged 1 commit into from
Apr 29, 2019
Merged

Use Gson for Json #84

merged 1 commit into from
Apr 29, 2019

Conversation

jaredsburrows
Copy link
Owner

@jaredsburrows jaredsburrows commented Apr 29, 2019 •
edited

  • Fix HTML and JSON indentation in tests
  • Fix HTML output
    • 2 space indent
    • Use of " instead of '
  • Fix JSON output
    • 2 space indent
  • Remove trim() and stripIndent()
  • Compare JSON and HTML by validating and comparing the data and not the format

@jaredsburrows jaredsburrows force-pushed the pr/jaredsburrows/use-gson-for-json-2 branch 5 times, most recently from 88b177e to dcb02ed Compare April 29, 2019 02:09
@jaredsburrows jaredsburrows changed the title use gson for json Use Gson for Json Apr 29, 2019
@jaredsburrows jaredsburrows force-pushed the pr/jaredsburrows/use-gson-for-json-2 branch from dcb02ed to 9773409 Compare April 29, 2019 02:51
@jaredsburrows jaredsburrows merged commit 8dbbd69 into master Apr 29, 2019
@jaredsburrows jaredsburrows deleted the pr/jaredsburrows/use-gson-for-json-2 branch April 29, 2019 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jaredsburrows