Update System Cost Methods #2
Conversation
|
Looks good, but I am concerned about circumventing the hybrid costs function (see comment). |
| pv_mw, | ||
| battery_mw, | ||
| battery_mwh) | ||
| # pv_cost, wind_cost, storage_cost, total_cost = self.cost_model.calculate_total_costs(wind_mw, |
There was a problem hiding this comment.
Overall this looks good, but I wonder if we should extend the calculate_total_costs function rather than circumventing it.
There was a problem hiding this comment.
I think ideally as we integrate full BOS and indirect costs it would be worth rewriting calculate_total_costs to be flexible and incorporate those aspects for a hybrid plant. As it stands now calculate_total_costs is only applicable to wind, pv and battery based on an outdated study for greenfields and uses an outdated ATB (2020).
Additionally, the method calculate_total_costs produces the same costs for each technology as the methods I wrote when using Singleowner as the financial model.
There was a problem hiding this comment.
Ok, if the results are the same we should be good. Thanks.
|
Accepting, but we do need to address the BOS costs in the future more directly. |
…ctionality Feature/onshore offshore functionality
set_overnight_capital_cost()toPowerSourceclasscalculate_total_installed_cost()toPowerSourceclassset_overnight_capital_cost()toBatteryclass, includesenergy_capital_costandpower_capital_costcalculate_total_cost()method fromCostCalculatorclass for determining wind, pv and battery costsCustomFinancialModel