Refactor app branch - never got this to work. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d fixed the edit notebook and add new notebook (almost completely working)
… get the way this is supposed to actually do things. woot!!! need to do: - fix tags up nice, - fix the NoteNav so counts update correctly for notebooks and tags
…s to work without the ability to store arrays tho huh doods?
…ting for edit notes working finally. need to make delete and the css of the tag field better
… delete tags finally done!
…ings, so for now i am putting in a new branch cuz its all broken now.
…being thrown away. as per usual. i suck
jaredwilli
commented
Sep 21, 2017
| * @param {*} note | ||
| * @param {*} allNoteTags | ||
| */ | ||
| export function editNoteTags(note, tags) { |
There was a problem hiding this comment.
could be useful stuff here
jaredwilli
commented
Sep 21, 2017
| dispatch(addNoteRejectedAction()); | ||
| }); | ||
| } | ||
| return dispatch => { |
jaredwilli
commented
Sep 21, 2017
| * @param {*} note | ||
| * @param {*} callback | ||
| */ | ||
| export function editTags(tags, note) { |
jaredwilli
commented
Sep 21, 2017
| * @param {*} notebook | ||
| */ | ||
| export function getNotebookCount(notes, notebook) { | ||
| let count = 0; |
There was a problem hiding this comment.
need all of this stuff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting PRs up for the branches I worked on, but dont intend to merge or use so I can view the code that I wrote for them.
With this branch I learned a large amount around working with firebase and how to keep track of unique ids in a normalized data structure. I'd like to reference the code easily, so putting it here.
Also, I did write a good amount of useful functions and other things for this which could be useful...