update jest ts-jest

[alphmt]

Please check if the PR fulfills these requirements

• Followed the Contributing guidelines.
• Tests for the changes have been added (for bug fixes/features) with 100% code coverage.
• Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
upgraded jest, ts-jest

[alphmt]

@jaredwray the FIREBASE_CERT & TWILLO_SENDGRIP_API_KEY are not defined, that is why tests are failing

[jaredwray]

@jaredwray the FIREBASE_CERT & TWILLO_SENDGRIP_API_KEY are not defined, that is why tests are failing

@alphmth - this was working before did something change in the code to not take in the environment variables?

[alphmt]

@jaredwray no.. There is only a change in package.json. Tests run locally fine.

[jaredwray]

@alphmth - it looks like something changed. Maybe with Jest where the environment variables are not being passed.

I just did a pull request using the same build.yml file and it worked: #157

[alphmt]

@jaredwray are these under environment secrets section?

prisma/prisma#10204 (comment)

[alphmt]

@jaredwray please approve workflow

[jaredwray]

prisma/prisma#10204 (comment)

Yep. they are under the repo section and work.

[alphmt]

@jaredwray The github secrets are not passed to runner when a workflow is triggered from for forked repo https://docs.github.com/en/actions/security-guides/encrypted-secrets#using-encrypted-secrets-in-a-workflow

But this can solve our problem:

https://dev.to/petrsvihlik/using-environment-protection-rules-to-secure-secrets-when-building-external-forks-with-pullrequesttarget-hci

[jaredwray]

Ah I see. What would be better is to remove the requirement for these two keys and to mock the tests. Can you set that up?

…

________________________________ From: alphmth ***@***.***> Sent: Wednesday, September 21, 2022 1:15 PM To: jaredwray/airhorn ***@***.***> Cc: Jared Wray ***@***.***>; Mention ***@***.***> Subject: Re: [jaredwray/airhorn] update jest ts-jest (PR #156) @jaredwray<https://github.com/jaredwray> The github secrets are not passed to runner when a workflow is triggered from for repo https://docs.github.com/en/actions/security-guides/encrypted-secrets#using-encrypted-secrets-in-a-workflow But this can solve our problem: https://dev.to/petrsvihlik/using-environment-protection-rules-to-secure-secrets-when-building-external-forks-with-pullrequesttarget-hci — Reply to this email directly, view it on GitHub<#156 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAJGJ2NN5R3YE5NTDL5IWXLV7NUF3ANCNFSM6AAAAAAQRLYHTE>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[alphmt]

@jaredwray ok I will set mocks

[jaredwray]

@alphmth - looks like no tests have ran.

Also, what is this.json?

[alphmt]

@jaredwray this.json is just dummy filename

[codecov]

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (c894baa) compared to base (3366e7b).
Patch has no changes to coverable lines.

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #156   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines          335       327    -8     
  Branches        56        54    -2     
=========================================
- Hits           335       327    -8     

Impacted Files	Coverage Δ
test/testing-data.ts	100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.