feat: optional refresh strategy (stale-while-revalidate) #533 #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jonathanarezki thanks for doing this pull request. I will be reviewing this in the next 10 days and get back to you on this. |
|
Also, please make sure to update your branch to the latest. |
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #586 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 283 292 +9
Branches 72 75 +3
=========================================
+ Hits 283 292 +9
📢 Have feedback on the report? Share it here. |
|
@jonathanarezki can you update the readme with this new functionality? |
added 3 commits
September 8, 2023 17:54
update: README.md
update: README.md
# Conflicts: # README.md
|
I updated the readme. |
update: tests to be less time sensitive in slow environments
jaredwray
approved these changes
Sep 8, 2023
|
@jonathanarezki - thanks and since this is not a non breaking change I will add it to the next release which should go out in the next couple weeks. |
|
Thank you really much. I didn't expect it to go that smooth. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added refresh threshold, to update stores before the ttl runs out.
Only the wrap function is affected.
If the the remaining ttl of a store is smaller than the refresh threshold,
the store gets set with the fn asynchronously.
The refresh threshold is optional and is not stored in the store it self, only in the cache instance as a config.