Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add refreshThreshold as parameter of wrap function. Fix #606 #630

Merged
merged 3 commits into from Jan 19, 2024

Conversation

lchenay
Copy link
Contributor

@lchenay lchenay commented Dec 29, 2023

Please check if the PR fulfills these requirements

  • Followed the Contributing guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8475076) 100.00% compared to head (620dd3f) 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #630   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          318       320    +2     
  Branches        78        79    +1     
=========================================
+ Hits           318       320    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jaredwray
Copy link
Owner

@lchenay - thanks for putting this together. Could you make sure to update the unit tests on this and also update the documentation?

@jaredwray
Copy link
Owner

@lchenay - any update on this?

@jaredwray
Copy link
Owner

@lchenay - any update on this? If not, I will close it out.

@lchenay
Copy link
Contributor Author

lchenay commented Jan 19, 2024

On it. Doing all this WE.

@lchenay
Copy link
Contributor Author

lchenay commented Jan 19, 2024

620dd3f is not directly related to this PR.
I can extract them to a new PR if interested and needed.

@lchenay lchenay marked this pull request as ready for review January 19, 2024 20:08
@jaredwray
Copy link
Owner

@lchenay - thanks so much. merging this now.

@jaredwray jaredwray merged commit 72c0d4a into jaredwray:master Jan 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants