Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CLI build command and fix issues #27

Merged
merged 20 commits into from
Jan 30, 2023
Merged

add CLI build command and fix issues #27

merged 20 commits into from
Jan 30, 2023

Conversation

cialese
Copy link
Collaborator

@cialese cialese commented Jan 19, 2023

Please check if the PR fulfills these requirements

  • Followed the Contributing guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

@jaredwray
Copy link
Owner

@cialese and @christianllv when will we have this done?

@chrisllontop
Copy link
Collaborator

@jaredwray will be ready tomorrow. We fixed the import.meta issue using mocks. Now, we will to complete the docula class test (we are on 90% of coverage) and will be done :)

@jaredwray
Copy link
Owner

great. lets get it to 100%

@chrisllontop
Copy link
Collaborator

for sure!

@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (73ef217) compared to base (b94200f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #27   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        15    +1     
  Lines          287       345   +58     
  Branches        37        44    +7     
=========================================
+ Hits           287       345   +58     
Impacted Files Coverage Δ
src/docula.ts 100.00% <100.00%> (ø)
src/plugins/github.ts 100.00% <100.00%> (ø)
src/plugins/index.ts 100.00% <100.00%> (ø)
src/plugins/sitemap.ts 100.00% <100.00%> (ø)
src/tools/inquirer-prompt.ts 100.00% <100.00%> (ø)
src/tools/tools.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jaredwray jaredwray merged commit 4d49b3e into main Jan 30, 2023
@cialese cialese deleted the cli branch February 6, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants