-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove rimraf? #59
Comments
I always align with the latest version eslint supports, if they also
support node > 14.14, then it might be possible.
Roy Ronald Riojas Montenegro
…On Sat, Aug 14, 2021 at 12:39 PM Jimmy Wärting ***@***.***> wrote:
rimraf comes with a large dependency:
***@***.***
maybe should consider dropping it and instead use nodes native rm
<https://nodejs.org/dist/latest-v16.x/docs/api/fs.html#fs_fspromises_rm_path_options>,
with recursive mode?
Would require node 14.14 doe...
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#59>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABABWW3ZR4WVLXUNEAIKX3T43A5LANCNFSM5CFMG6JQ>
.
|
it looks like you are only deleting files and not using any glob patterns, maybe it could be simplified to just use |
@jimmywarting - I am game to remove rimraf with just custom code to do the work. |
@jimmywarting - going to do an minor update supporting 12 so we have that in place for legacy clients. Then the plan is to move this to >=14 over the next couple months. Will remove rimraf then. |
@jimmywarting - The next published release going out (~30 days) will be a major version bum and moving to v14 as the minimum. |
@jaredwray any update on this? |
we had to wait on this but will make the change on it in January 2024 with a major version bump |
Ah ok no worries.
…On Tue, 12 Dec 2023, 16:58 Jared Wray, ***@***.***> wrote:
we had to wait on this but will make the change on it in January 2024 with
a major version bump
—
Reply to this email directly, view it on GitHub
<#59 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHOFWX23PRHG5V6WBVT2PCDYJCEMJAVCNFSM5CFMG6J2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBVGI2DGOBXGUYQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
@The-Code-Monkey - major version release to set us up to make rimraf a devDependency moving forward and will add in our own delete functionality. |
#87 has the removal of rimraf as a core dependency |
We will release this in the upcoming month with our standard release schedule. |
rimraf comes with a large dependency: https://npmgraph.js.org/?q=flat-cache@3.0.4
maybe should consider dropping it and instead use nodes native rm, with recursive mode?
Would require node 14.14 doe...
Can make a PR if u like
The text was updated successfully, but these errors were encountered: