Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove rimraf? #59

Closed
jimmywarting opened this issue Aug 14, 2021 · 11 comments
Closed

remove rimraf? #59

jimmywarting opened this issue Aug 14, 2021 · 11 comments

Comments

@jimmywarting
Copy link

jimmywarting commented Aug 14, 2021

rimraf comes with a large dependency: https://npmgraph.js.org/?q=flat-cache@3.0.4
maybe should consider dropping it and instead use nodes native rm, with recursive mode?

Would require node 14.14 doe...

Can make a PR if u like

@royriojas
Copy link
Contributor

royriojas commented Aug 16, 2021 via email

@jimmywarting
Copy link
Author

jimmywarting commented Oct 12, 2021

it looks like you are only deleting files and not using any glob patterns, maybe it could be simplified to just use fs.unlinkSync(path)?

@jaredwray
Copy link
Owner

@jimmywarting - I am game to remove rimraf with just custom code to do the work.

@jaredwray
Copy link
Owner

@jimmywarting - going to do an minor update supporting 12 so we have that in place for legacy clients. Then the plan is to move this to >=14 over the next couple months. Will remove rimraf then.

@jaredwray
Copy link
Owner

@jimmywarting - The next published release going out (~30 days) will be a major version bum and moving to v14 as the minimum.

@The-Code-Monkey
Copy link

@jaredwray any update on this?

@jaredwray
Copy link
Owner

we had to wait on this but will make the change on it in January 2024 with a major version bump

@The-Code-Monkey
Copy link

The-Code-Monkey commented Dec 12, 2023 via email

@jaredwray
Copy link
Owner

@The-Code-Monkey - major version release to set us up to make rimraf a devDependency moving forward and will add in our own delete functionality.

@jaredwray
Copy link
Owner

#87 has the removal of rimraf as a core dependency

@jaredwray
Copy link
Owner

We will release this in the upcoming month with our standard release schedule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants