redis - fixing error again on calling clear with empty keys (#977)

#964
jaredwray · Jan 8, 2024 · d7d5e11 · d7d5e11
1 parent 11c7fd1
commit d7d5e11
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/packages/redis/src/index.ts b/packages/redis/src/index.ts
@@ -129,7 +129,9 @@ class KeyvRedis<Value = any> extends EventEmitter {
 		} else {
 			const pattern = 'sets:*';
 			const keys: string[] = await this.redis.keys(pattern);
-			await this.redis.unlink(keys);
+			if (keys.length > 0) {
+				await this.redis.unlink(keys);
+			}
 		}
 	}
 

diff --git a/packages/redis/test/test.ts b/packages/redis/test/test.ts
@@ -183,3 +183,16 @@ test.serial('del should work when not using useRedisSets', async t => {
 
 	t.is(value, undefined);
 });
+
+test.serial('clear method with empty keys should not error', async t => {
+	const keyv = new KeyvRedis(redisURI);
+
+	await t.notThrowsAsync(keyv.clear());
+});
+
+test.serial('clear method when useRedisSets is false and empty keys should not error', async t => {
+	const options = {useRedisSets: false};
+	const keyv = new KeyvRedis(options);
+
+	await t.notThrowsAsync(keyv.clear());
+});