Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node-sqlite3 appears to be somewhat abandoned and has been racking up security vulnerabilities in its dependencies. This PR switches it to better-sqlite3 which is more performant, supports more architectures, and is actively maintained.
This PR also switches to using Bind Parameters which resolves an issue I was experiencing when storing values that contain a single quote (
'
).Note: I didn't really understand what was going on with the
TestAdapter
, so I just reverted these changes. The tests seem to still pass from what I see, although you may want to re-run manually to double check.I understand this is a big change, so if you feel you want to stick with node-sqlite3 and just resolve its security vulnerabilities (like this solution), I can just port this module into a standalone package. However, you still may want to consider switching to bind parameters, which node-sqlite3 also offers.