Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for electron-builder #9

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

safu9
Copy link

@safu9 safu9 commented Nov 24, 2018

electron-builder uses flat dir structure of icons unlike electron-packager.
I added the option to flatten output structure.
It is disabled by default.

(And, I adjust some indents. If you feel this adjustment unnecessary, no problem to ignore.)

@lazerwalker
Copy link

Wanted to bump / put in a vote of confidence for this!

I'm currently flattening my output structure with a few lines of bash in my processing pipeline (https://github.com/lazerwalker/tracery-dot-app/blob/b3f0bf2022faac7560a5accfaee446424d0ae167/package.json#L14) but this is a much nicer solution.

@nklayman
Copy link

@safu9 since this isn't getting any attention, why don't you make a separate package (electron-builder-icon-maker) so that we don't have to install from your git repo. Thanks!

@lazerwalker
Copy link

Makes sense to me, although it is sad to see this project flounder.

I'm happy to put in the gruntwork of forking + pushing to npm + maintaining if @safu9 doesn't want to. Will probably sit down to do that later this week or early next week if it hasn't happened yet or if @safu9 hasn't chimed in one way or another.

@safu9
Copy link
Author

safu9 commented Feb 20, 2019

Thanks. I'll do it propably within this week or next week. I'm thinking its new name is electron-icon-builder, more simply.

@safu9
Copy link
Author

safu9 commented Feb 25, 2019

I just published electron-icon-builder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants