Fix for transforming methods in ES6 object shorthand form #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
...which fails locally but not on Travis. |
|
Okay, Travis build fixed in c6d0d2f. Rebasing this PR in a bit. |
jareware
force-pushed
the
bug-object-shorthand
branch
from
a7df7d8
to
bc5c11b
Compare
|
/cc @phadej :) |
jareware
force-pushed
the
bug-object-shorthand
branch
from
bc5c11b
to
84c8bd8
Compare
|
Is this some kind of ES6 shortcut, for defining object properties, which are functions? |
|
Exactly that, I think they're called "methods". Actually, seems that within I'll look into this more in a bit... |
…e there's no regressions in their parsing in the presence of "ES6 methods".
jareware
added a commit
that referenced
this pull request
Jan 18, 2015
Fix for transforming methods in ES6 object shorthand form
| .replace(/\/\*\s*:([\s\S]+?)\*\//g, ': $1'); // /* : FooBar */ => : FooBar | ||
|
|
||
| // If this is an "ES6 method" function, its return-type annotation is included as leadingComments | ||
| if (node.parent.method && node.leadingComments) { |
There was a problem hiding this comment.
this one is in between of node's header updating
jareware
added a commit
that referenced
this pull request
Jan 19, 2015
…ding another failing fixture.
|
Fair enough! Let's fix it while fixing this #6... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the previous release there's a regression in transforming the form:
By a quick look it seems that
leadingCommentsare attached to theFunctionExpression, as opposed to theBlockStatementbody of the function.Added a failing test case.