Default celerity to set accept header to "text/html" rather than "*/*" and add override mechanism.

[wolframarnold]

HTMLUnit sends the first request to a server with accept header set to "/". This causes some servers to not respond with HTML and is probably not what's intended. For a more detailed discussion, see here: http://stackoverflow.com/questions/4824028/celerity-cannot-follow-a-devise-redirect-because-celerity-doesnt-send-an-accept

I've added the ability to set the accept header explicitly in the Browser#goto method. If it's not set, it'll default to "text/html" rather than "/". This change was TDD's and tests are included.

[jarib]

HtmlUnit should ideally match the Accept header used by the browser being emulated (as specified through the :browser constructor option in Celerity / BrowserVersion in HtmlUnit). I'd prefer if you raised a bug with them about this, and changed the patch to not modify the headers unless the user explicitly passes in the headers hash.

Thanks!

[jarib]

Firefox defaults to:

text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8

and Chromium to

application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5

[jarib]

I'm about to release 0.8.9, please address my previous comment if you want to get this in.

[wolframarnold]

Hi, Jari,

Thanks for the shout-out. I've not had time to fix this. I have raised it with the HTMLUnit guys and filed a bug report there. I agree with your suggestion to leave the default behavior as is and override as needed, but I've not had the bandwidth to pick this back up.

In my application I've worked around the issue with a small rack middleware patch that sets the accept header explicitly if it's missing.

Don't let this hold up your release, and thanks for checking back.

Wolf

[jarib]

Thanks for the quick reply - I'll pull it in and fix that one line myself :)

[wolframarnold]

Thanks you're the best!
On Mar 28, 2011 4:51 PM, "jarib" <
reply@reply.github.com>
wrote:

Thanks for the quick reply - I'll pull it in and fix that one line myself
:)

Reply to this email directly or view it on GitHub:
#49 (comment)