Add method to filter a page's entries by time, resolves #9 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
robertam3
approved these changes
Mar 26, 2019
| time = page.started_date_time + 0.250 | ||
| entries = page.entries_before(time) | ||
| entries.each do |entry| | ||
| (entry.started_date_time + entry.time / 1000.to_f).should < time |
There was a problem hiding this comment.
Could we use expect instead of should here?
expect(entry.started_date_time + entry.time / 1000.to_f).to be < timeThere was a problem hiding this comment.
We can, but I was going with consistency with the current style using RSpec 2.0, figuring a larger task would be to bump to 3.8 and update specs in general to the more modern matcher style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.