Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove colon token from function definition and move return type afte… #84

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joczkowski
Copy link
Contributor

Proposed Changes

IMO it is not necessary to use arrow before brackets , beter is rust like syntax

image

@joczkowski joczkowski force-pushed the change_function_arrow_syntax branch from a353a33 to 2ed5902 Compare July 26, 2023 16:16
@joczkowski joczkowski force-pushed the change_function_arrow_syntax branch from 2ed5902 to 77f7160 Compare July 26, 2023 16:16
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.39% ⚠️

Comparison is base (143746c) 74.15% compared to head (2ed5902) 73.77%.

❗ Current head 2ed5902 differs from pull request most recent head 77f7160. Consider uploading reports for the commit 77f7160 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
- Coverage   74.15%   73.77%   -0.39%     
==========================================
  Files          38       38              
  Lines        1482     1487       +5     
==========================================
- Hits         1099     1097       -2     
- Misses        383      390       +7     
Files Changed Coverage Δ
src/parser.rs 81.10% <ø> (-2.18%) ⬇️
src/compiler/mod.rs 82.89% <100.00%> (+0.07%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant