Don't use finally block for tag fallback

Signed-off-by: gnattu <gnattuoc@me.com>
jarno9981 · May 28, 2024 · 97d7151 · 97d7151
1 parent 475fa36
commit 97d7151
Showing 1 changed file with 10 additions and 12 deletions.
diff --git a/MediaBrowser.Providers/MediaInfo/AudioFileProber.cs b/MediaBrowser.Providers/MediaInfo/AudioFileProber.cs
@@ -191,18 +191,16 @@ private async Task FetchDataFromTags(Audio audio, Model.MediaInfo.MediaInfo medi
             {
                 _logger.LogWarning(e, "TagLib-Sharp does not support this audio");
             }
-            finally
-            {
-                tags ??= new TagLib.Id3v2.Tag();
-                tags.AlbumArtists ??= mediaInfo.AlbumArtists;
-                tags.Album ??= mediaInfo.Album;
-                tags.Title ??= mediaInfo.Name;
-                tags.Year = tags.Year == 0U ? Convert.ToUInt32(mediaInfo.ProductionYear, CultureInfo.InvariantCulture) : tags.Year;
-                tags.Performers ??= mediaInfo.Artists;
-                tags.Genres ??= mediaInfo.Genres;
-                tags.Track = tags.Track == 0U ? Convert.ToUInt32(mediaInfo.IndexNumber, CultureInfo.InvariantCulture) : tags.Track;
-                tags.Disc = tags.Disc == 0U ? Convert.ToUInt32(mediaInfo.ParentIndexNumber, CultureInfo.InvariantCulture) : tags.Disc;
-            }
+
+            tags ??= new TagLib.Id3v2.Tag();
+            tags.AlbumArtists ??= mediaInfo.AlbumArtists;
+            tags.Album ??= mediaInfo.Album;
+            tags.Title ??= mediaInfo.Name;
+            tags.Year = tags.Year == 0U ? Convert.ToUInt32(mediaInfo.ProductionYear, CultureInfo.InvariantCulture) : tags.Year;
+            tags.Performers ??= mediaInfo.Artists;
+            tags.Genres ??= mediaInfo.Genres;
+            tags.Track = tags.Track == 0U ? Convert.ToUInt32(mediaInfo.IndexNumber, CultureInfo.InvariantCulture) : tags.Track;
+            tags.Disc = tags.Disc == 0U ? Convert.ToUInt32(mediaInfo.ParentIndexNumber, CultureInfo.InvariantCulture) : tags.Disc;
 
             if (audio.SupportsPeople && !audio.LockedFields.Contains(MetadataField.Cast))
             {