Merge pull request jellyfin#11698 from Bond-009/issue11605

Fix not binding to SQL parameters
jarno9981 · May 17, 2024 · d303ca5 · d303ca5
2 parents 26714e2 + dd0ab8e
commit d303ca5
Showing 1 changed file with 3 additions and 9 deletions.
diff --git a/Emby.Server.Implementations/Data/SqliteItemRepository.cs b/Emby.Server.Implementations/Data/SqliteItemRepository.cs
@@ -2323,7 +2323,7 @@ SELECT albumValues.ItemId
 
                 columns.Add(builder.ToString());
 
-                query.ExcludeItemIds = [..query.ExcludeItemIds, item.Id, ..item.ExtraIds];
+                query.ExcludeItemIds = [.. query.ExcludeItemIds, item.Id, .. item.ExtraIds];
                 query.ExcludeProviderIds = item.ProviderIds;
             }
 
@@ -2831,7 +2831,7 @@ private string GetOrderByText(InternalItemsQuery query)
                     prepend.Add((ItemSortBy.Random, SortOrder.Ascending));
                 }
 
-                orderBy = query.OrderBy = [..prepend, ..orderBy];
+                orderBy = query.OrderBy = [.. prepend, .. orderBy];
             }
             else if (orderBy.Count == 0)
             {
@@ -5144,7 +5144,7 @@ private List<(int MagicNumber, string Value)> GetItemValuesToSave(BaseItem item,
             list.AddRange(inheritedTags.Select(i => (6, i)));
 
             // Remove all invalid values.
-            list.RemoveAll(i => string.IsNullOrEmpty(i.Item2));
+            list.RemoveAll(i => string.IsNullOrWhiteSpace(i.Item2));
 
             return list;
         }
@@ -5202,12 +5202,6 @@ private void InsertItemValues(Guid id, List<(int MagicNumber, string Value)> val
 
                         var itemValue = currentValueInfo.Value;
 
-                        // Don't save if invalid
-                        if (string.IsNullOrWhiteSpace(itemValue))
-                        {
-                            continue;
-                        }
-
                         statement.TryBind("@Type" + index, currentValueInfo.MagicNumber);
                         statement.TryBind("@Value" + index, itemValue);
                         statement.TryBind("@CleanValue" + index, GetCleanValue(itemValue));