remove readonly

jarno9981 · Aug 21, 2023 · e7016e3 · e7016e3
1 parent 791413a
commit e7016e3
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 16 deletions.
diff --git a/Emby.Server.Implementations/Data/BaseSqliteRepository.cs b/Emby.Server.Implementations/Data/BaseSqliteRepository.cs
@@ -98,7 +98,7 @@ public virtual void Initialize()
             }
         }
 
-        protected SqliteConnection GetConnection(bool readOnly = false)
+        protected SqliteConnection GetConnection()
         {
             var connection = new SqliteConnection($"Filename={DbFilePath}");
             connection.Open();

diff --git a/Emby.Server.Implementations/Data/SqliteItemRepository.cs b/Emby.Server.Implementations/Data/SqliteItemRepository.cs
@@ -1273,7 +1273,7 @@ public BaseItem RetrieveItem(Guid id)
 
             CheckDisposed();
 
-            using (var connection = GetConnection(true))
+            using (var connection = GetConnection())
             using (var statement = PrepareStatement(connection, _retrieveItemColumnsSelectQuery))
             {
                 statement.TryBind("@guid", id);
@@ -1956,7 +1956,7 @@ public List<ChapterInfo> GetChapters(BaseItem item)
             CheckDisposed();
 
             var chapters = new List<ChapterInfo>();
-            using (var connection = GetConnection(true))
+            using (var connection = GetConnection())
             using (var statement = PrepareStatement(connection, "select StartPositionTicks,Name,ImagePath,ImageDateModified from " + ChaptersTableName + " where ItemId = @ItemId order by ChapterIndex asc"))
             {
                 statement.TryBind("@ItemId", item.Id);
@@ -1975,7 +1975,7 @@ public ChapterInfo GetChapter(BaseItem item, int index)
         {
             CheckDisposed();
 
-            using (var connection = GetConnection(true))
+            using (var connection = GetConnection())
             using (var statement = PrepareStatement(connection, "select StartPositionTicks,Name,ImagePath,ImageDateModified from " + ChaptersTableName + " where ItemId = @ItemId and ChapterIndex=@ChapterIndex"))
             {
                 statement.TryBind("@ItemId", item.Id);
@@ -2557,7 +2557,7 @@ public int GetCount(InternalItemsQuery query)
             var commandText = commandTextBuilder.ToString();
 
             using (new QueryTimeLogger(Logger, commandText))
-            using (var connection = GetConnection(true))
+            using (var connection = GetConnection())
             using (var statement = PrepareStatement(connection, commandText))
             {
                 if (EnableJoinUserData(query))
@@ -2625,7 +2625,7 @@ public List<BaseItem> GetItemList(InternalItemsQuery query)
             var commandText = commandTextBuilder.ToString();
             var items = new List<BaseItem>();
             using (new QueryTimeLogger(Logger, commandText))
-            using (var connection = GetConnection(true))
+            using (var connection = GetConnection())
             using (var statement = PrepareStatement(connection, commandText))
             {
                 if (EnableJoinUserData(query))
@@ -2833,7 +2833,7 @@ public QueryResult<BaseItem> GetItems(InternalItemsQuery query)
 
             var list = new List<BaseItem>();
             var result = new QueryResult<BaseItem>();
-            using var connection = GetConnection(true);
+            using var connection = GetConnection();
             using var transaction = connection.BeginTransaction();
             if (!isReturningZeroItems)
             {
@@ -3141,7 +3141,7 @@ public List<Guid> GetItemIdsList(InternalItemsQuery query)
             var commandText = commandTextBuilder.ToString();
             var list = new List<Guid>();
             using (new QueryTimeLogger(Logger, commandText))
-            using (var connection = GetConnection(true))
+            using (var connection = GetConnection())
             using (var statement = PrepareStatement(connection, commandText))
             {
                 if (EnableJoinUserData(query))
@@ -4723,7 +4723,7 @@ public List<string> GetPeopleNames(InternalPeopleQuery query)
             }
 
             var list = new List<string>();
-            using (var connection = GetConnection(true))
+            using (var connection = GetConnection())
             using (var statement = PrepareStatement(connection, commandText.ToString()))
             {
                 // Run this again to bind the params
@@ -4761,7 +4761,7 @@ public List<PersonInfo> GetPeople(InternalPeopleQuery query)
             }
 
             var list = new List<PersonInfo>();
-            using (var connection = GetConnection(true))
+            using (var connection = GetConnection())
             using (var statement = PrepareStatement(connection, commandText))
             {
                 // Run this again to bind the params
@@ -5003,7 +5003,7 @@ private List<string> GetItemValueNames(int[] itemValueTypes, IReadOnlyList<strin
 
             var list = new List<string>();
             using (new QueryTimeLogger(Logger, commandText))
-            using (var connection = GetConnection(true))
+            using (var connection = GetConnection())
             using (var statement = PrepareStatement(connection, commandText))
             {
                 foreach (var row in statement.ExecuteQuery())
@@ -5203,8 +5203,8 @@ private QueryResult<(BaseItem Item, ItemCounts ItemCounts)> GetItemValues(Intern
             var list = new List<(BaseItem, ItemCounts)>();
             var result = new QueryResult<(BaseItem, ItemCounts)>();
             using (new QueryTimeLogger(Logger, commandText))
-            using (var connection = GetConnection(true))
-            using (var transaction = connection.BeginTransaction())
+            using (var connection = GetConnection())
+            using (var transaction = connection.BeginTransaction(deferred: true))
             {
                 if (!isReturningZeroItems)
                 {
@@ -5557,7 +5557,7 @@ public List<MediaStream> GetMediaStreams(MediaStreamQuery query)
 
             cmdText += " order by StreamIndex ASC";
 
-            using (var connection = GetConnection(true))
+            using (var connection = GetConnection())
             {
                 var list = new List<MediaStream>();
 
@@ -5945,7 +5945,7 @@ public List<MediaAttachment> GetMediaAttachments(MediaAttachmentQuery query)
             cmdText += " order by AttachmentIndex ASC";
 
             var list = new List<MediaAttachment>();
-            using (var connection = GetConnection(true))
+            using (var connection = GetConnection())
             using (var statement = PrepareStatement(connection, cmdText))
             {
                 statement.TryBind("@ItemId", query.ItemId);

diff --git a/Emby.Server.Implementations/Data/SqliteUserDataRepository.cs b/Emby.Server.Implementations/Data/SqliteUserDataRepository.cs
@@ -267,7 +267,7 @@ public UserItemData GetUserData(long userId, string key)
 
             ArgumentException.ThrowIfNullOrEmpty(key);
 
-            using (var connection = GetConnection(true))
+            using (var connection = GetConnection())
             {
                 using (var statement = connection.PrepareStatement("select key,userid,rating,played,playCount,isFavorite,playbackPositionTicks,lastPlayedDate,AudioStreamIndex,SubtitleStreamIndex from UserDatas where key =@Key and userId=@UserId"))
                 {