Update displayed naming and avoid duplicated sensors from api #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change naming convention to either parameter.category+parameter.name+(parameter.id) or parameter.name+(parameter.id) this is done to reveal the point-id from myuplink since many sensors tend to be called the same thing (at least for Nibe). The removal of device is because of duplication in naming that caused confusion in finding the correct sensor in lookup
Check for duplication in parameters from the api. This is to avoid unneccesary sensors as there are quite a few of these examples (again for Nibe, don't know of others). This change also removes
|
Example from my instance running the new code.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr aims to further improve the readability of the many many sensors we get from myuplink, at least with certain hvac-types.
See if you approve, i have removed the device_id from the name as it was obscuring the readability. I also added the id in parenthesis in the end.
Furthermore, in api.py i've introduced a check for duplicated points since i've seen that these do occur. Imo this should not be possible but to prevent issues or missmatching sensors in HA I suggest we patch it like this til it's fixed on the myuplink-side.
When reviewing this, please do consider any implications the renaming may have for future sensor_ids. The current ids should stay the same as they did with my instance.
Also check so that you agree with my distinct-selection in api.py
Thanks.