AWS session token support #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sort Linux distributions and simplify/standardize grammar.
src/curl.cpp
Outdated
| @@ -1194,6 +1195,17 @@ bool S3fsCurl::SetAccessKey(const char* AccessKeyId, const char* SecretAccessKey | |||
| return true; | |||
| } | |||
|
|
|||
| bool S3fsCurl::SetAccessKeyWithSessionToken(const char* AccessKeyId, const char* SecretAccessKey, const char* SessionToken) | |||
| { | |||
| if((!S3fsCurl::is_ibm_iam_auth && (!AccessKeyId || '\0' == AccessKeyId[0])) || !SecretAccessKey || '\0' == SecretAccessKey[0] || !SessionToken || '\0' == SessionToken[0]){ | |||
There was a problem hiding this comment.
add multiple lines
bool accessKey = !AccessKeyId || '\0' == AccessKeyId[0])
...
if (!S3fsCurl::is_ibm_iam_auth && accessKey || SecretAccess
src/s3fs.cpp
Outdated
| @@ -4680,6 +4710,10 @@ static int my_fuse_opt_proc(void* data, const char* arg, int key, struct fuse_ar | |||
| is_ibm_iam_auth = true; | |||
| return 0; | |||
| } | |||
| if (0 == strcmp(arg, "use_session_token")) { | |||
There was a problem hiding this comment.
why cannot we use STR2NCMP macro as is used bellow?
Remove custom cppcheck from ppc64le Travis config
Address shellcheck errors
Mostly small fixes but also some reordering. References s3fs-fuse#929. Found via: diff -u <(man --no-hyphenation doc/man/s3fs.1 | tr -s ' ' '\n' | sed '/^-o$/d' ) <(src/s3fs --help | tr -s ' ' '\n' | sed '/^-$/d')
michallula
force-pushed
the
master
branch
4 times, most recently
from
560a524
to
a8e88df
Compare
Standardize installation section
Make man page and --help more consistent
AWS session token support
This prohibits missing semicolons.
This provides compatibility with C++03 and removes duplicate lookups.
Address markdownlint warnings
Prefer simple over compound statements in macros
Remove uses of std::map::at
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issue
Where to put
aws_session_tokeninformation s3fs-fuse#651Details
AWS Session Token support