Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent !0 in passwords #17

Closed
wants to merge 1 commit into from
Closed

Conversation

GregorGk
Copy link

My password contained !0 which prevented docker from running correctly. It was interpreted by Bash.
The fix was to use inverted commas like these: '(...)!0(...)'.

@stv0g
Copy link
Collaborator

stv0g commented Mar 12, 2021

Hi @GregorGk thanks for your PR 🎉

However, I would vote not to merge this PR as by convention you dont see apostrophes to be used in the synopsis of commands. This synopsis/usage info of the command is not intended to be used directly.

Rather it really depends which shell do you use. Not all shells use apostrophes for quoting..

@stv0g
Copy link
Collaborator

stv0g commented Mar 12, 2021

@jaroslawhartman what do you think about it?

@dbaker-rh
Copy link
Contributor

Came in to add an unrelated PR of my own. As this is a recent request, I support stv0g's opinion that the PR should not be merged.

The user would reasonably be expected to escape any special characters according to their local needs. Same applies for exclamation points, spaces, etc and wouldn't only be limited to the password field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants