Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve arguments() showing empty keys when exsiting short-only option #318

Merged
merged 2 commits into from May 11, 2022

Conversation

ldeng-ustc
Copy link
Contributor

@ldeng-ustc ldeng-ustc commented Dec 3, 2021

Solve #317

Before this PR:

$ ./example --list -x 1        
list = true
 = 1            # expect "x = 1" here
range = false (default)
compile = false (default)
...

After:

$ ./example --list -x 1        
list = true
x = 1          # OK
range = false (default)
compile = false (default)

This change is Reviewable

@jarro2783
Copy link
Owner

Thanks, can you write a unit test?

@ldeng-ustc
Copy link
Contributor Author

I add check on arguments() key and value in short option unit test, and write a new unit test for iterator.

@jarro2783
Copy link
Owner

Thanks for your PR.

@jarro2783 jarro2783 merged commit c59e0c1 into jarro2783:master May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants