Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disaster is not currently working on all M Mac family #29

Closed
MacPapo opened this issue Mar 9, 2023 · 4 comments
Closed

Disaster is not currently working on all M Mac family #29

MacPapo opened this issue Mar 9, 2023 · 4 comments

Comments

@MacPapo
Copy link
Contributor

MacPapo commented Mar 9, 2023

Hi @abougouffa I seen that you are the new maintainer.
I'm trying to run disaster on a M1 Mac and there is no way that I can compile with the current flags.
GCC doesn't support yet the native comp for M chips family, I created a simple patch for this and I would like to create a Pull Request.

@abougouffa
Copy link
Collaborator

Hello @MacPapo ,

Thank you for the PR. I've left some comments on your code.

@MacPapo
Copy link
Contributor Author

MacPapo commented Mar 10, 2023

I'm sorry @abougouffa but I can't see them, where can I find them? This is my first PR...

@abougouffa
Copy link
Collaborator

No problem @MacPapo , congratulations on your first PR!

Code reviews and comments are available in the "Files changed" section of the PR. As in the following figure:

image

abougouffa added a commit that referenced this issue Mar 10, 2023
@abougouffa
Copy link
Collaborator

Thanks you for the fix @MacPapo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants