Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenBSD needs -lcurses #26

Closed
sjmulder opened this issue Dec 16, 2018 · 2 comments
Closed

OpenBSD needs -lcurses #26

sjmulder opened this issue Dec 16, 2018 · 2 comments

Comments

@sjmulder
Copy link
Contributor

sjmulder commented Dec 16, 2018

On OpenBSD 6.4-STABLE, compilation of master fails:

$ gmake
cc -O3 -Wall -Wextra -Wno-unused-parameter -Werror -Iinc -o bcal src/bcal.c -lreadline
/usr/bin/../lib/libreadline.so.4.0: undefined reference to `tgetnum'
/usr/bin/../lib/libreadline.so.4.0: undefined reference to `tgoto'
/usr/bin/../lib/libreadline.so.4.0: undefined reference to `tgetflag'
/usr/bin/../lib/libreadline.so.4.0: undefined reference to `tputs'
/usr/bin/../lib/libreadline.so.4.0: undefined reference to `tgetent'
/usr/bin/../lib/libreadline.so.4.0: undefined reference to `tgetstr'

Adding -lcurses fixes the issue:

$ gmake LDLIBS="-lreadline -lcurses"
cc -O3 -Wall -Wextra -Wno-unused-parameter -Werror -Iinc -o bcal src/bcal.c -lreadline -lcurses
$

Not sure if it's safe to add -lcurses by default.

@jarun
Copy link
Owner

jarun commented Dec 16, 2018

Now that you have made LDLIBS flexible, I think you can take care of this downstream. bcal doesn't use ncurses.

@sjmulder
Copy link
Contributor Author

It's readline that uses the functions. Odd because readline is used on every platform and OpenBSD uses GNU readline like everyone else.

In any case if you don't feel good about including it here I'll do it downstream.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants