Skip to content

Commit

Permalink
Python 3.5 is EOL, add 3.9
Browse files Browse the repository at this point in the history
  • Loading branch information
jarun committed Oct 10, 2020
1 parent e69447d commit 8b128d1
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 11 deletions.
12 changes: 6 additions & 6 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,6 @@ test-template: &test-template
python3 -m pytest ./tests/test_*.py --cov buku -vv --durations=0
jobs:
py35:
docker:
- image: python:3.5-slim
<<: *test-template

py36:
docker:
- image: python:3.6-slim
Expand All @@ -47,6 +42,11 @@ jobs:
- image: python:3.8-slim
<<: *test-template

py39:
docker:
- image: python:3.9-slim
<<: *test-template

package-and-publish:
machine: true
working_directory: ~/Buku
Expand Down Expand Up @@ -101,10 +101,10 @@ workflows:

test:
jobs: &all-tests
- py35
- py36
- py37
- py38
- py39

nightly:
triggers:
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ There are several [projects based on `buku`](#related-projects), including a bro

| Feature | Dependency |
| --- | --- |
| Scripting language | Python 3.5+ |
| Scripting language | Python 3.6+ |
| HTTPS | certifi, urllib3 |
| Encryption | cryptography |
| HTML | beautifulsoup4, html5lib |
Expand Down
4 changes: 2 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
author_email='engineerarun@gmail.com',
url='https://github.com/jarun/buku',
license='GPLv3',
python_requires='>=3.5', # requires pip>=9.0.0
python_requires='>=3.6', # requires pip>=9.0.0
platforms=['any'],
py_modules=['buku'],
install_requires=[
Expand Down Expand Up @@ -101,10 +101,10 @@
'Operating System :: OS Independent',
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3 :: Only',
'Programming Language :: Python :: 3.5',
'Programming Language :: Python :: 3.6',
'Programming Language :: Python :: 3.7',
'Programming Language :: Python :: 3.8',
'Programming Language :: Python :: 3.9',
'Topic :: Internet :: WWW/HTTP :: Indexing/Search',
'Topic :: Utilities'
]
Expand Down
4 changes: 2 additions & 2 deletions tox.ini
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[tox]
envlist = python35,python36,python37,python38,pylint,flake8
envlist = python36,python37,python38,python39,pylint,flake8

[flake8]
max-line-length = 139
Expand Down Expand Up @@ -51,7 +51,7 @@ commands =

[testenv:pylint]
deps = pylint
whitelist_externals =
whitelist_externals =
/usr/bin/find
commands =
find . -iname "*.py" -not -path "./.tox/*" -not -path "./build/*" -exec pylint --rcfile tests/.pylintrc \{\} +
Expand Down

3 comments on commit 8b128d1

@jarun
Copy link
Owner Author

@jarun jarun commented on 8b128d1 Oct 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rachmadaniHaryono I tried to enable python v3.9. Can you please check if this is our issue (complains gcc missing) or an issue with the docker image... attached the logs.
log.zip

@rachmadaniHaryono
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is pr for multidict about this aio-libs/multidict#535 . yarl have similar issue but different environment aio-libs/yarl#526

imo skip python3.9 and try again when multidict pr accepted

@jarun
Copy link
Owner Author

@jarun jarun commented on 8b128d1 Oct 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing! Thank you!

Please sign in to comment.