Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests no longer work #686

Closed
LeXofLeviafan opened this issue May 1, 2023 · 1 comment · Fixed by #687
Closed

Unit tests no longer work #686

LeXofLeviafan opened this issue May 1, 2023 · 1 comment · Fixed by #687
Labels

Comments

@LeXofLeviafan
Copy link
Collaborator

As of now, unit tests run by tox are outright failing due to incompatibilities between dependency libraries (caused by recently released new versions of some of them).

To fix this, the files setup.py, requirements.txt & bukuserver/requirements.txt need to be updated with the following changes, at least for the time being:

  • Flask>=2.2.2,<2.3 (2.3 has json_encoder property missing, which causes HTTP 500 on several queries)
  • urllib3>=1.23,<2 (2.0 doesn't have VerifiedHTTPSConnection, which breaks pytest itself of all things)
@jarun
Copy link
Owner

jarun commented May 1, 2023

Please raise the PR.

LeXofLeviafan added a commit to LeXofLeviafan/buku that referenced this issue May 1, 2023
@jarun jarun closed this as completed in #687 May 1, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants