create setup.cfg #416
Closed
create setup.cfg #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rachmadaniHaryono please take a look. |
|
i think the based on this https://setuptools.readthedocs.io/en/latest/setuptools.html#configuring-setup-using-setup-cfg-files you have to put the actual list of package. is it possible to exclude bukuserver with env var instead moving the section to setup.cfg? |
|
@stkw0 all CI tests have failed. Please check that as well. |
jarun
force-pushed
the
master
branch
3 times, most recently
from
efd8c5e
to
6bfe505
Compare
I was not able to fix. Seems that pip doesn't support parsing requirements from setup.cfg, although setup.py works. |
|
Closing the PR as unresolved. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Gentoo we where trying to find a way to enable/disable the installation of buku web server and I was suggested to move that to setup.cfg (I didn't know what setup.cfg was before that). This patch tries to move bukuserver related things to setup.cfg but I'm not completely sure this is the right way.
See also gentoo/gentoo#10332 (comment) for the related discussion.