New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suddenly stopped working #115
Comments
There is some change in the service. i can fetch the first page with the following patch: diff --git a/ddgr b/ddgr
index 39510e6..647718e 100755
--- a/ddgr
+++ b/ddgr
@@ -705,7 +705,7 @@ class DdgConnection:
"""
def __init__(self, proxy=None, ua=''):
- self._u = 'https://duckduckgo.com/html'
+ self._u = 'https://html.duckduckgo.com/html'
self._proxies = {
'https': proxy if proxy is not None else (os.getenv('https_proxy') However, fetching the next page still fails and I am not sure why. Please see if you can debug and figure this out. I can't spend time on this. |
Other things that would fail are bangs, tab-completion, |
Yes, it must be due to a change in DDG's API. I get the same "No Results" message from the version packaged for Ubuntu 20.04 $ dpkg -l ddgr
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name Version Architecture Description
+++-==============-=========================-============-=================================
ii ddgr 1.7+git20190928.bccdc92-2 all DuckDuckGo from the terminal
$ ddgr -d Ubuntu 20.04
[DEBUG] ddgr version 1.7 Python version 3.8.2
[DEBUG] q:Ubuntu 20.04, region:us-en, page:0, curindex:1, safe:1
[DEBUG] nextParams:
[DEBUG] proxy:{'https': None}
[DEBUG] ua:ddgr/1.7 (textmode; Linux x86_64; 1024x768)
[DEBUG] Response body written to '/tmp/ddgr-response-sxfn32q0'.
[DEBUG] Prev nextParams:
[DEBUG] Next nextParams:
No results.
ddgr (? for help) NOTE: When I run the latest code that includes the update referenced above, I have no problem navigating to the next or previous page, and bangs seem to work fine. |
Same problem here. |
Same here |
Guys, I know it's there. Unfortunately, I do not have the time to debug and fix every aspect of it. |
@jarun: Could you expand on the troubles you're experiencing? I just tried a couple things now, using a freshly-cloned
$ ddgr --
--colors --help --num --unsafe
--debug --json --proxy --url-handler
--ducky --nocolor --reg --version
--expand --noprompt --show-browser-logs
--gb --noua --site
--gui-browser --np --time
$ ddgr --d
--debug --ducky
$ ddgr --ducky (that last command auto-completed after I entered |
Thanks for checking it out. In that case I think the only issue is next and prev. You can compare the data sent from firefox (for next) in developer mode with what ddgr sends. Please see if that gives a hint. |
Sorry, I didn't mean option completion by auto-completion. in ddgr you could also complete possible search terms earlier. That is not working. Bangs are also not working. Try the 4th example: https://github.com/jarun/ddgr#examples |
I wasn't aware ddgr had search-term auto-completion. How did that work? Just type (a portion of) a word and hit tab? Where? On the commandline? At the interactive prompt? Regarding bangs: I'm running inside a Linux Docker container without a GUI browser so I can't test your 4th example exactly, but both
|
You are right! Bangs are working. I am on zsh and missed the
That's correct. At he commandline. And I see it is working in bash.
In fact I missed both these cases as I switched to zsh nowadays. So we are back to only next and prev are not working. |
Interesting...I tried tab completion at the commandline earlier and it didn't seem like it was working. Tried again now and discovered that I have to hit tab twice before it offers suggestions. |
That's correct. |
@cmonfortep noticed you actively contribute to the DDG android app project. Can you/refer someone who can help us with fetching the next and previous pages? |
Hi @jarun. I will try to ping someone from the backend team and see if they can comment here. 👍 |
Thank you so much! |
For what it's worth, I'm using Ubuntu 18.04 which is capped at Enter Is there any kind of debug information I can provide regarding getting |
Not really. You are only viewing the results of the first fetch (first 30). Do next 3 times and then you'll see the next 30 results fetch fail.
I think fetching next page fails because there is some change required in the data we send to fetch the next page. The server is expecting something else. You can debug by comparing with the data Firefox sends (you cna see it in Web Developer -> Network). Note: I am not in a position to work on this now. There's enough info on how/what to debug in this thread. Someone has to pick it up. |
Quite right. Thanks for the clarification.
…On Mon, Jul 13, 2020 at 5:24 PM Jana ***@***.***> wrote:
everything works, even next and prev
Not really. You are only viewing the results of the first fetch (first
30). Do next 3 times and then you'll see the next 30 results fetch fail.
Is there any kind of debug information I can provide regarding getting
next and prev working generally?
I think fetching next page fails because there is some change in the data
we send to fetch the next page. The server is expecting something else. You
can debug by comparing with the data Firefox sends (you cna see it in Web
Developer -> Network).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#115 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADCTGIBGPQENWXNMC6YYODR3OJT3ANCNFSM4OMUF7HA>
.
|
Fixed at #117. 👍 |
hm-hm... 1.8.1 from
(ignore the ERROR - it always here) And I couldn't find that And, yes, it has still |
v1.8.1 will not work. Wait for the next release or use master. The fix is in master. |
@jarun sorry I didn't respond you back about this. I reported the issue internally but I've not been actively following it (I'm enjoying some days off 😅). Glad to see this was solved. |
No problem! Thank you! |
Guys, I have released ddgr v1.9 tonight: https://github.com/jarun/ddgr/releases/tag/v1.9 Everything works as before! |
Greetings,
Can ping duckduckgo.com (no replies but contactable)
Can use duckduckgo.com from chrome
some debug output:
PING google.com (172.217.20.110) 56(84) bytes of data.
64 bytes from ams17s01-in-f14.1e100.net (172.217.20.110): icmp_seq=1 ttl=117 time=39.3 ms
64 bytes from ams17s01-in-f14.1e100.net (172.217.20.110): icmp_seq=2 ttl=117 time=38.9 ms
64 bytes from ams17s01-in-f14.1e100.net (172.217.20.110): icmp_seq=3 ttl=117 time=39.2 ms
64 bytes from ams17s01-in-f14.1e100.net (172.217.20.110): icmp_seq=4 ttl=117 time=38.8 ms
--- google.com ping statistics ---
4 packets transmitted, 4 received, 0% packet loss, time 3005ms
rtt min/avg/max/mdev = 38.834/39.043/39.297/0.202 ms
[kmiller@KEM-B9]~:ping -c4 duckduckgo.com
PING duckduckgo.com (40.114.177.156) 56(84) bytes of data.
--- duckduckgo.com ping statistics ---
4 packets transmitted, 0 received, 100% packet loss, time 3061ms
[kmiller@KEM-B9]~:ddgr -d ubuntu 20.04
[DEBUG] ddgr version 1.8.1 Python version 3.8.2
[DEBUG] q:ubuntu 20.04, region:us-en, page:0, curindex:1, safe:1
[DEBUG] nextParams:
[DEBUG] proxy:{'https': None}
[DEBUG] ua:ddgr/1.8.1 (textmode; Linux x86_64; 1024x768)
[DEBUG] Response body written to '/tmp/ddgr-response-tixs8svt'.
[DEBUG] Prev nextParams:
[DEBUG] Next nextParams:
No results.
ddgr (? for help)
cat /tmp/ddgr-response-tixs8svt
<title>DuckDuckGo</title>The text was updated successfully, but these errors were encountered: