Disable Colors on Windows unless ENABLE_VIRTUAL_TERMINAL_PROCESSING is set

[guilt]

The ANSI sequences/colors only work when enabled within a process on Windows.

To do that, one has to roughly do the equivalent of:

  DWORD lpMode;
  HANDLE hOut = GetStdHandle(STD_OUTPUT_HANDLE);
  GetConsoleMode(hOut, &lpMode);
  lpMode |= ENABLE_VIRTUAL_TERMINAL_PROCESSING;
  SetConsoleMode(hOut, lpMode);

and then call print() in Python. I know that pywin32 supports calling these functions, but as of now, these specific functions are not implemented yet in an available whl/release.

So, you'd have to set them yourself for it to work across Win32. The other option is disable colors on Windows till this is implemented.

I'm just reporting this so this can be useful to folks like me. :)

[jarun]

You can disable colors. Please use the option -C, --nocolor.

[jarun]

Does that work for you?

[guilt]

I understand that option, but the default shouldn't be true without getopt. It should be a detected value.

It only makes this tool unusable out of the box unless people know how to ignore the escape sequences.

[jarun]

I must admit Windows support is not great in ddgr. I don't use Windows myself. Please raise a PR for this.

[guilt]

Raised a PR #87

[jarun]

Thank you!

[jarun]

Closing the issue. Need to wait for the relevant patch in googler.