-
-
Notifications
You must be signed in to change notification settings - Fork 534
TODO list #69
Comments
@jarun Your TODO list. We could link it from README if you like it. Anything I'm missing at the moment? |
Linking from readme is very much necessary. This covers for the time... now that we already have a deb package. I'll take care of the doc stuff. |
Right, deb package... It's a WIP, so it should still be listed. Added to the list with a link to the PR. |
I think we could safely cross out Windows installation, because I just tried and it doesn't even work... For one, apparently Then, At that point I shutdown my VM out of frustration, so I don't know if there are other problems... Seeing that no one ever reported, it's safe to assume that we have no Windows users at all. |
I updated the readme accordingly. :) Many thanks for pointing it out. We don't wanna misguide our users. If you do have a |
Will try. I do have licenses for all Windows releases since XP... But do you realize Microsoft offer official VM images that don't require a license and are typically good for 60 days (or maybe 30) from initial boot? https://developer.microsoft.com/en-us/microsoft-edge/tools/vms/linux/. (Looks like they have taken down XP images, but I have archived XP download URLs too, here: https://gist.github.com/zmwangx/e728c56f428bc703c6f6) |
Okay, so I tried googler on Windows again without
|
Interestingly, I just noticed
That The link in source is |
As for Buku, on a fairly vanilla Windows 10 install, there's no |
I donno what to say.
Should be fine. But we need to check whether it is valid or not too.
True, and when it's not available it should create the DB file in the same dir. |
Sorry, you mean "percent-decode should be fine", or "not percent-decode should be fine"? I was wrong in saying
When it's not available, you get an exception when you try to |
Yes, I checked it the first time. It fails. I meant that we need to fix it. Show it as it comes to us.
I will check it out. Seems like I need to download a Windows image ;). Thanks for the VM image links. |
The fix is trivial enough: diff --git a/googler b/googler
index f7e0e5c..ba6f387 100755
--- a/googler
+++ b/googler
@@ -39,7 +39,6 @@ if sys.version_info > (3,):
from urllib.parse import (
urljoin,
quote_plus as url_quote_plus,
- unquote as url_unquote,
)
from http.client import HTTPSConnection
@@ -50,7 +49,6 @@ else:
import HTMLParser
from urllib import (
quote_plus as url_quote_plus,
- unquote as url_unquote,
)
from urlparse import urljoin
from httplib import HTTPSConnection
@@ -159,8 +157,7 @@ class GoogleParser(HTMLParser.HTMLParser):
if self.url != "":
if self.url.find("://", 0, 12) >= 0:
index = len(self.results) + 1
- self.results.append(Result(index, self.title,
- url_unquote(self.url),
+ self.results.append(Result(index, self.title, self.url,
self.text))
else:
skipped += 1 Basically, just don't unquote. However, I'm not sure if it will have side effects. Interestingly enough, although |
Yes, I tried the same just now. Works. The original bug was:
Note the %22 for ". I am all ears for your opinion here.
Doesn't work for me when I try to open result 2. |
That URL works for me... What's the problem?
Then it's OS X doing the smartass thing. |
Trying to be perfect if possible ;). I'll add https://github.com/jarun/Buku/blob/master/buku#L796. |
I would say a working implementation trumps a pretty but broken one...
No strong objection. By the way, I'm be out for a hour or two. Won't be able to reply until I get back. |
Wait, no. On second thought (I'll try to write a proof-of-concept web app that handle |
OK then.
Enjoy your day! |
Sorry, I pushed it before seeing this. Feel free to check out a better way of handling this. |
Back to RFCs.
Therefore, U+0022 Quotation Mark isn't even an allowed character in either URI or IRI. Which is very obvious because URI/IRIs should be embeddable in HTML, and HTML attributes are wrapped in double quotes. Many (if not most) modern browsers are smart enough to automatically quote the quotation mark when it appears in an actually-invalid URI, but there's no guarantee that this will work in all browsers. Erring on the safe side, I would not do this. (Not to mention |
To elaborate a bit on my last point: if you support |
OK OK. Consider it gone. 💃 |
BTW, if you have a collection of soothing traditional Cantonese music (lyrics-less is what I'm looking for), do share. |
Missed that... Unfortunately I don't 😉 My early training in music leans on the (Western) classical side, and I mostly listen to Chinese/South Korean pop music these days; either case, no lyrics-less traditional Cantonese music. |
I would like to add support for sitelinks. I'll implement this sooner or later. |
Awesome! Please add to the list. |
See chatroom for some questions. |
I think googler has accumulated enough complexity (1270 lines, close to 1000 if you take out comments) to the point that changes to one part of the program may break another part subtly, and since our test script only tests the core functionality, and worse, only watches for obvious failures, we risk introducing regressions. e159a44 is an example, although that's an embarrassingly simple one easily caught by static analysis. Therefore, I'm thinking about unit tests. But in order to write unit tests, we first need to make googler importable. Which means wrapping up bare code into functional units and have a Once we have the code contained, we can stop relying on Google leniently allowing us a few hundred queries. We can easily build up a couple thousand or more responses to a wide range of queries over a day or two, then do whatever we want with those queries. (And we can update the response repertoire once in a while; the test script can also do a few realtime queries to make sure there's no breaking change on Google's part.) The interactive parts are certainly somewhat harder to test, but I'm sure there are ways to stub things out and test them given a little bit more thought. This will be a pretty significant undertaking, and I don't think either of us will have time to do this soon, but just want to put this idea out for scrutiny. |
It will be a nice improvement but we can't do this ourselves. We should add this in ToDo. Please link to your comment above. |
I don't feel too strongly about this, but here's an idea: since the colors chosen by us don't always look nice in all color schemes (honestly it doesn't even look so good with my slightly localized Solarized Dark: ), we should offer a way to customize it. An option, |
By the way, isn't that a cute screenshot? 😉 |
Your hold on generating beautiful images/videos is unparalleled. BTW, are you into photography? |
Not at all... |
Try it |
As a stay-at-home type of person and selfie hater, the main channels are closed. I do occasionally take a shot when I see something beautiful though. More on topic, what do you say about colors? Please reply at your leisure. |
Do you mean colour presets? That would be a valuable addition. But if we want users to fiddle around with it (custom colours), we will be concentrating more on colours than other features. A set of defined presets would be great. |
BTW, we need a new asciinema with the new prompt. Please add the prompt help as well. Your latest change makes it way more organized. |
I am planning a new release next weekend. Please let me know if your are fine. Can we pull-in preset colours by that time? |
No, because implementing color presets is actually more work for us. With BSD-style
and that's all. Our default is also a five-letter string. Then we use a tiny color map (BSD has 16 colors + default, we should add reverse video too, so 18), and bam, done. In order to have presets, you basically need to do all of the above, AND you need to be a good designer, AND even then you can't make everyone happy. (I know one one has complained thus far, just like I didn't, but maybe it's because it's too small an issue; but it's always nice to have the customizability there.) I'm not a designer, although I am somewhat into visual design, so there's it. |
I'll do that prior to the release.
No problem. |
I get it now. The |
Added to the top, will do it when I have time, probably during the weekend or even before that when I don't feel like getting other work done... |
No hurry :) |
By the way, what do you think about rolling the todo list thread? With > document.getElementsByClassName('timeline-comment-wrapper').length
45 comments and > document.body.offsetHeight
13054 vertical pixels, this one is getting kind of a pain to scroll. Can we start a new thread (copy over top post while getting rid of archived items) once in a while? |
sure! |
Roll. New thread at #83. |
Rolling TODO list thread No. 1. This thread has been archived. Continue discussion in #83.
Possible improvements we'd like to see:
And moonshots:
PRs welcome!
Archived:
Easier installation on Windows (viachoco
?)Won't fix — we don't support Windows and have no Windows users.Actually we might as well be able to support Windows, given that one uses a less hostile environment: Augment compat layer to improve portability #70.The text was updated successfully, but these errors were encountered: